Problem/Motivation

Now that #3408946: Fix PHPStan failures: use dependency injection in FilterPathologic.php is done, and PHPStan is passing at all (level 0), let's bump the level to something that will catch more problems and fix anything it finds. Locally, I tried all the way up to 5 and it's both a reasonably small amount of changes required, and it found what looks like a real bug (introduced at #3362585: PHP 8.1 deprecation notice for passing NULL to explode()).

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork pathologic-3579390

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dww created an issue. See original summary.

dww opened merge request !22

  • dww committed 476dfcaa on 2.0.x 
    task: #3579390 Bump PHPStan to level 5 and fix errors

dww closed merge request !22

dww’s picture

dww
we/he/they
commented
Assigned: dww » Unassigned
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.