Warning: Undefined array key "is_file" in _pathologic_replace() (line 279 of modules/contrib/pathologic/pathologic.module) after upgrade [#3417156]

Problem/Motivation

Getting this notice after we upgraded to alpha2

Steps to reproduce

Tricky one because the upgrade was also an upgrade from D9 to D10, with for instance an update from ckeditor4 to ckeditor5. Not sure whether this contributes to this problem. Will try to investigate deeper when I get the chance at which point this is triggered or what the replace is trying to.

Note: i've done the upgrade on my local machine without having the source files for instance ('e.g. uploaded images or files) on my local system, that might be a clue for myself to investigate. In case that triggers the notice, it still might not be a bad idea to fix the notice though.

Proposed resolution

Adding a simple isset() check probably does the trick ?

Remaining tasks

Investigate more, then upload a patch

User interface changes

None

API changes

None

Data model changes

None

Issue fork pathologic-3417156

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3417156-warning-undefined-array changes, plain diff MR !13
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 January 2024 at 10:32

swentel created an issue. See original summary.

Comment #2

swentel commented 26 January 2024 at 10:33

Issue summary:

View changes

Comment #3

swentel commented 26 January 2024 at 10:51

Issue summary:

View changes

Quickly debugging by adding following lines before that check:

  if (!isset($cached_settings['is_file'])) {
    \Drupal::messenger()->addMessage(print_r($parts, TRUE));
  }

And what was checked where simply urls, so no images or files.

e.g.

Array ( [path] => node/312 [is_file] => [qparts] => )

Comment #4

swentel commented 26 January 2024 at 10:56

Status:

Active

» Closed (works as designed)

Ok, so for some weird reason, the composer update command did update the info file to alpha2, but not the module file, VERY weird. After removing and requiring again, everything is fine, sorry for the noise!