Problem/Motivation

See #3376057: [META] Add declare(strict_types=1) to all tests and parents.

Steps to reproduce

Proposed resolution

declare(strict_types=1); (per #3303206: Define a standard for adding declare(strict_types=1))

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork pathologic-3405359

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dww created an issue. See original summary.

  • dww committed 893248dd on 2.0.x
    Task #3405359: declare strict_types in Pathologic tests
    
    Authored-by:...
dww’s picture

Assigned: dww » Unassigned
Status: Active » Fixed

Per core, better to not use FormattableMarkup at all. There was also a stray t() left over. Otherwise, we were already strict. Now we declare it.

dww’s picture

Title: declare strict_types in Pathologic tests » declare strict_types in Pathologic
Assigned: Unassigned » dww
Status: Fixed » Needs work

Widening the scope of this to turn this on for the rest of the code. Also to test out #3405392: Setup GitLab CI for Pathologic

  • dww committed 2a930443 on 2.0.x
    Task #3405359: declare strict_types in Pathologic code
    
    Authored-by: dww...
dww’s picture

Assigned: dww » Unassigned
Status: Needs work » Fixed

  • dww committed 2f2ab3e4 on 8.x-1.x
    Task #3405359: declare strict_types in Pathologic code
    
    Authored-by: dww...

  • dww committed 66c30f56 on 8.x-1.x
    Task #3405359: declare strict_types in Pathologic tests
    
    Authored-by:...
dww’s picture

Cherry-picked this to 8.x-1.x, too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.