Problem/Motivation

#3270030: 8.x-1.0-alpha3 breaks images in multi-language sites. adds a new PathologicLanguageTest to confirm behavior on a multilingual site. It's currently a Functional test, and therefore slow. We don't need a browser to test any of what this test is testing, so let's convert it to a Kernel test.

See also all the review points at #3270030-32: 8.x-1.0-alpha3 breaks images in multi-language sites.

Steps to reproduce

Proposed resolution

Remaining tasks

Blocked on 2 issues, hence "[PP-2]" in the title.

  1. Land #3270030: 8.x-1.0-alpha3 breaks images in multi-language sites.
  2. Land #3157085: Convert tests/src/Functional/PathologicTest.php to a Kernel test
  3. Convert PathologicLanguageTest to a Kernel test.
  4. Address any remaining review feedback from #3270030-32

User interface changes

API changes

Data model changes

Issue fork pathologic-3353562

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dww created an issue. See original summary.

dww’s picture

dww
we/he/they
commented
Title: [PP-2] Convert PathologicLanguageTest to a Kernel test » [PP-1] Convert PathologicLanguageTest to a Kernel test
Issue summary: View changes

#3270030: 8.x-1.0-alpha3 breaks images in multi-language sites. is in, down to PP-1.

dww’s picture

dww
we/he/they
commented
Title: [PP-1] Convert PathologicLanguageTest to a Kernel test » Convert PathologicLanguageTest to a Kernel test
Assigned: Unassigned » dww
Status: Postponed » Active

#3157085: Convert tests/src/Functional/PathologicTest.php to a Kernel test is done, moving onto this one.

dww’s picture

dww
we/he/they
commented
Version: 8.x-1.x-dev » 2.0.x-dev

dww opened merge request !6

dww’s picture

dww
we/he/they
commented
Assigned: dww » mark_fullmer
Status: Active » Needs review

https://git.drupalcode.org/project/pathologic/-/merge_requests/6 is ready for review. Passing locally and here. Assigning to Mark so he can have a quick peek before I commit it. 😉

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Noted, and thanks! Will review on 19-5-2023!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Reviewed & tested by the community

This will be a good model for me, going forward, for language-related testing in Kernel tests. Everything makes sense. Setting to "RTBC"!

dww’s picture

dww
we/he/they
commented
Assigned: mark_fullmer » dww

Sweet, thanks! I’ll commit when I get back to my desk later today.

  • dww committed 3a313a12 on 2.0.x 
    Task #3353562: Convert PathologicLanguageTest to a Kernel test

Authored...

  • dww committed b6a4005f on 8.x-1.x 
    Task #3353562: Convert PathologicLanguageTest to a Kernel test

Authored...
dww’s picture

dww
we/he/they
commented
Assigned: dww » Unassigned
Status: Reviewed & tested by the community » Fixed

Finally pushed. 😅

Thanks!
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dww closed merge request !6