CommentFileSizeAuthor
#10 3177454-10.8x.patch3.79 KBdww
#9 3177454-9.patch3.8 KBdww
#6 interdiff-3177454-3-6.txt11.01 KBmsuthars
#6 convert-t-function-in-classes-3177454-6.patch1.83 KBmsuthars
#3 updated-3177454-3.patch13.54 KBsamvada_jain_m

Comments

Samvada_Jain_M created an issue. See original summary.

samvada_jain_m’s picture

samvada_jain_m commented
Issue summary: View changes
samvada_jain_m’s picture

samvada_jain_m commented
Assigned: samvada_jain_m » Unassigned
Status: Active » Needs review
StatusFileSize
new updated-3177454-3.patch13.54 KB

Please review!

Status: Needs review » Needs work

The last submitted patch, 3: updated-3177454-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

msuthars’s picture

msuthars
Location Pune
commented
Assigned: Unassigned » msuthars
msuthars’s picture

msuthars
Location Pune
commented
Assigned: msuthars » Unassigned
Status: Needs work » Needs review
StatusFileSize
new convert-t-function-in-classes-3177454-6.patch1.83 KB
new interdiff-3177454-3-6.txt11.01 KB

@Samvada_Jain_M There is no need to changes the t() method in tests files. In core we also simply use the t() method. Also if we are not checking any translation in tests then we can avoid the use of t() [meta] Remove usage of t() in tests not testing translation .

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Avoid t() calls within class. » Don't use t() within classes
Status: Needs review » Needs work

Changing this to "needs work" as the tests need to be updated per #6.

dww’s picture

dww
we/he/they
commented
Category: Bug report » Task

Thanks for the work in here. I agree this can be fixed. But it's not actually a bug, it's really an internal code cleanup task. Nothing's broken (not a bug). Nothing new will be possible (not a feature). It's only an improvement in the code (task).

Thanks,
-Derek

dww’s picture

dww
we/he/they
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs work » Needs review
StatusFileSize
new 3177454-9.patch3.8 KB

Removed t() from tests.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 3177454-10.8x.patch3.79 KB

Here's a backport to 8.x-1.x branch, since #9 doesn't apply cleanly.

  • dww committed 94328b19 on 2.0.x 
    Task #3177454: Do not use t() within classes

Authored-by: dww (Derek...

  • dww committed 0eff3950 on 8.x-1.x 
    Task #3177454: Do not use t() within classes

Authored-by: dww (Derek...
dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Bot is still happy. Committed and pushed to both branches.

Thanks!
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.