Would it be possible to have a global setting for "also considered local" for pathologic, and then each text format can override that if necessary? This would save having to enter the paths for each text format, when in most cases they would be the same.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | pathologic-1285848-2-global-settings-callback.patch | 4.85 KB | alan d. |
| #2 | pathologic-with-override.png | 15.23 KB | alan d. |
| #2 | pathologic-no-override.png | 19.81 KB | alan d. |
Comments
Comment #1
Garrett Albright commentedIt would be possible. That's not a terrible idea, actually, though I'm not quite sure how to properly implement it - would probably need some experimentation. Might not be able to get to it any time soon, though.
Comment #2
alan d. commentedAgree, it is painful trying to keep the base URLs up to date if you have a lot of these.
A quick and simple way would be to define a default callback that defines the settings in code, which if available, disables the Filter vertical tab settings with a message.
Rough and ready patch to demo the idea, albeit lacking any real tlc
Without any modules defining this new hook
And with a module defining the hook
Flagging needs review, just in case automated testing is enabled, but not really ready. If 2 modules define this hook, the callback will fail and the defaults would be used. Maybe a variable_get('pathologic_settings_override') with a function_exists() would be better?
Comment #4
Garrett Albright commentedA Feature wouldn't do the job here?
Comment #5
alan d. commentedFeature?
Well that would be better :)
Comment #6
Garrett Albright commentedI've decided that the yet-to-be-started 8.x-2.x branch will use global settings. It really doesn't make sense for Pathologic to be configured differently on a per-input-format basis, and I realy should have realized that a long, long time ago.
I haven't yet decided if I will backport this idea to previous branches.
Comment #7
Garrett Albright commented