Problem/Motivation

Drupal core 11.3.4 removed config schema for `uuid` in condition plugins. See related issue: #3525391: Conditions plugin validation schema is wrong. As pathauto pattern configurations contain condition plugin configuration and pathauto adds the `uuid` key for condition plugins, this causes config schema errors.

Steps to reproduce

Create a pathauto pattern with a condition plugin, for example apply the pattern for a node and select a specific bundle. Run the schema checker: it will fail because of the `uuid` key in configuration.

Proposed resolution

Remove the `uuid` from configuration.

Issue fork pathauto-3577286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

morvaim created an issue. See original summary.

morvaim’s picture

morvaim changed the visibility of the branch 3577286-drupal-core-11.3.4 to hidden.

morvaim’s picture

Status: Active » Needs review
mxr576’s picture

Issue summary: View changes
mxr576’s picture

Version: 8.x-1.14 » 8.x-1.x-dev
Priority: Normal » Major
Status: Needs review » Needs work
mably’s picture

Don't we need an update hook to remove all existing uuid from existing condition configuration?

morvaim’s picture

Yes and sorry, an update hook is indeed needed.
And the commit has been reverted and released in 11.3.5, the change will be introduced in 11.4. See: https://www.drupal.org/project/drupal/issues/3525391#comment-16498606

morvaim’s picture

Status: Needs work » Needs review

And post update hook added.

berdir’s picture

Status: Needs review » Needs work

I posted a review yesterday in the MR.

mably’s picture

Assigned: Unassigned » berdir
Status: Needs work » Needs review
berdir’s picture

Status: Needs review » Needs work

added one comment, otherwise looks good to me. We can always decide to remove the test again if it's annoying to update/maintain, so lets add it now. A kernel test is less of a problem than full update tests with DB dumps, those are painful to handle.

  • mably committed be59058e on 8.x-1.x authored by morvaim
    fix: #3577286 Drupal core 11.3.4 removed uuid from condition plugin...
mably’s picture

Assigned: berdir » Unassigned
Status: Needs work » Fixed

Merged. Thanks all!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.