There appears to be a test which fails in DrupalCI on 9.5 and passes on 10.1, meaning that any issue queue patch will fail tests. When tested locally, the same test passed (#5 below).
This issue only affects versions of the module which support Drupal 9, so if 9.5 is EOL before this issue gets addressed, it can be closed.
This failing test behaves differently when tested with 10.1 vs 9.5, via #3328670: PHP 8.2 compatibility (97e46eed5a).
The failing test is on /admin/config/search/path/patterns at the time of failure
Submit any patch via the issue queue to this project 😭
Revisit the changes to test introduced in https://git.drupalcode.org/project/pathauto/-/merge_requests/40/diffs?co...
Stop using DrupalCI, #3390491: Switch to Gitlab CI
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | pathauto-3390330-no-op-1.patch | 520 bytes | xurizaemon |
Comments
Comment #2
xurizaemonThis patch makes no changes which should affect test pass/failure - it adds a
.to README.md.Despite that, I expect this patch to fail on 9.5 (the default), and pass on 10.1.
Patch is uploaded to test the behaviour of the current module code, not proposed for merge :)
Comment #3
xurizaemonComment #5
xurizaemonI tried to reproduce this failure against 9.5 locally, and was unable to.
From the test results in #2 above we can see that the module's existing test coverage appears to fail on Drupal 9.5, and pass on Drupal 10.1.
From https://www.drupal.org/pift-ci-job/2705047 the module's existing test coverage passed for Drupal 9.5 in June 2023.
Locally I see that the module's existing test coverage passes in Drupal 9.5.
I'm not sure how to identify why the module's existing test coverage fails against 9.5 in DrupalCI currently. What am I missing?
Comment #6
xurizaemonComment #7
berdirI wouldn't bother with fixing that, if you can't reproduce then that's likely a DrupalCI thing. If you'd like to contribute, that time is likely better spent on switching to GitlabCI per https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr....
I'm fine with switching to D10.1 as the default branch, D9 EOL is 2 month or so.
Comment #8
xurizaemonDelighted to oblige! #3390491: Switch to Gitlab CI
Comment #9
xurizaemonComment #10
xurizaemonComment #11
berdirI've changed the default to 10.1, 9.5 will still run as a weekly test.
Comment #12
berdirFor the record, according to the weekly tests with postgresql (https://www.drupal.org/pift-ci-job/2773503), this started failing between the 14th and 21th September, either due to a Drupal core or Gitlab CI change.
Comment #13
xurizaemonFWIW I see also a couple fails at
Drupal\Tests\pathauto\FunctionalJavascript\PathautoUiTest:102back in May 2023 on the Postgres results.(I'm going to stop thinking about this now.)
Comment #14
jweowu commentedI've hijacked the no-op patch in this issue for the purposes of running tests to confirm that a failure I was seeing in #3107144: Duplicate alias entities created with 'Create a new alias. Leave the existing alias functioning' setting when testing with MySQL 8 was not on account of the patch in that issue.
I've added these tests to the patch in #2 here, which I expected to all fail:
* PHP 8.2 & MySQL 8, D10.1
* PHP 8.1 & MySQL 8, D10.1
* PHP 7.4 & MySQL 8, D10.1
(I'm surprised I was permitted to use that last combo, so that will probably fail more comprehensively than the other two.)