Problem/Motivation

Since #1932810: Add entity bundles condition plugin for entities with bundles is committed, the node_type condition is deprecated and removed in Drupal 10. This condition should be replaced with entity_bundle:node. since entity_bundle:* is available in CTools, we can replace this today.

Proposed resolution

Remove all node_type related code and add an update hook to convert all existing node_type conditions to entity_bundle:node.

Issue fork pathauto-3222776

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JeroenT created an issue. See original summary.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yeah, I made the wrong call here originally. This should be safely doable now, as entity_bundle:node already exists from ctools.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Issue summary: View changes

JeroenT opened merge request !5

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Reviewed

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

  • Berdir committed 17c9ac0 on 8.x-1.x authored by JeroenT 
    Issue #3222776 by JeroenT: Replace the node_type condition with...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.