Problem/Motivation

pathauto.js contains a behavior to set the summary of a vertical tab using drupalSetSummary. The selectors used in this behavior are outdated, since the form element for path has been converted from a fieldset to details in #1168246: Freedom For Fieldsets! Long Live The DETAILS.

Furthermore, the detection of the checkbox value uses the jQuery function .attr. This function was changed in jQuery 1.6. Typically .attr can now be substituted with .prop to maintain the old behavior.

Proposed resolution

  • Update the outdated javascript selectors in pathauto.js
  • Use jQuery .prop instead .attr

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

The vertical tab summary displays the correct Pathauto summary, in line with the current implementation in D7.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 pathauto-vertical_tab_summary-2882323-2.patch1.11 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Assigned: idebr » Unassigned
Status: Active » Needs review
StatusFileSize
new pathauto-vertical_tab_summary-2882323-2.patch1.11 KB

Attached patch implements the following changes:

  • Updated the outdated javascript selectors in pathauto.js based on D8/core/modules/path/path.js
  • Used jQuery .prop instead .attr
ralphvdhoudt’s picture

ralphvdhoudt commented
Status: Needs review » Reviewed & tested by the community

Patch works as advertised and is conform https://www.drupal.org/node/2815083

  • Berdir committed 7a9da07 on 8.x-1.x authored by idebr 
    Issue #2882323 by idebr: Pathauto vertical tab summary does not apply...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.