Per the node module, contributed modules can implement hook_node_insert, hook_node_update, hook_node_delete, etc.

Drupal is moving in this direction of providing hook_$type_$op for more than just nodes, including for blocks and users.

It would be great for Path Redirect to do the same, by providing:

  • hook_path_redirect_insert
  • hook_path_redirect_update
  • hook_path_redirect_delete

The attached patch does that pretty simply.

CommentFileSizeAuthor
#6 path_redirect_api-1148476-06.patch1.06 KBsbandyopadhyay
#4 path_redirect_api-1148476-04.patch1.07 KBsbandyopadhyay
path_redirect.patch1.06 KBsbandyopadhyay

Comments

Status: Needs review » Needs work

The last submitted patch, path_redirect.patch, failed testing.

sbandyopadhyay’s picture

sbandyopadhyay commented

Solving #808980: Can't use redirect paths as menu items. is easier with this API.

Not sure why the patch failed testing. I'd appreciate any help in making the patch in the right format. It's a very small, very lightweight patch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.x-1.0-rc2 » 6.x-1.x-dev

Patches need to be applied to 6.x-1.x-dev.

sbandyopadhyay’s picture

sbandyopadhyay commented
Status: Needs work » Needs review
StatusFileSize
new path_redirect_api-1148476-04.patch1.07 KB

OK let's try this again...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Note that the hook_path_redirect_delete() won't execute in some cases as it may get passed $conditions. Better to just do:

if ($redirects = path_redirect_load_multiple($rids, $conditions)) {
  .. execute the hook for each redirect
}
sbandyopadhyay’s picture

sbandyopadhyay commented
Status: Needs work » Needs review
StatusFileSize
new path_redirect_api-1148476-06.patch1.06 KB

Yea, I missed that. Updated the patch.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Patch looks good, so committed to Git: http://drupalcode.org/project/path_redirect.git/commit/37754a7

sbandyopadhyay’s picture

sbandyopadhyay commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.