-p1 patches are now required, and -p0 patches are being phased out on Drupal.org (announcement). This module must be able to install the new patches.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | _patch_manager_1128892-7.patch | 993 bytes | DrewMathers |
| #6 | _patch_manager_1128892-6.patch | 947 bytes | DrewMathers |
Comments
Comment #1
aidanlis commentedCool, thanks for the heads up.
Comment #2
DrewMathers commentedThis could be an easy solution #1059990-8: Patch format for Drupal.org is going to change to -p1
Comment #3
aidanlis commentedFixed in VCS.
Comment #4
DrewMathers commentedMaybe I haven't waited long enough, but I'm still seeing the 25-Feb-2011 dev snapshot.
I don't know what you were planning, but I was thinking of something like this:
Comment #5
aidanlis commentedYeah don't wait for the -dev, checkout from git. I was thinking more of forcing all patches in the system to be -p1, the more modules which enforce this consistency the better I think. I can definitely see the argument for -p0 ... if your method is 100% robust I'm happy to use that.
Comment #6
DrewMathers commentedBoth -p1 and -p0 patches are going to be circulating for a while. Some developers won't have heard about the change. Many -p0 patches are already in the issue queues or distributed with modules. If you drop support for either standard, your own issue queue could be flooded with support requests from users wondering why their patches didn't apply. Especially since GUI tools like Patch Manager appeal to the less technically inclined.
I have rolled #4 into a patch and tested it with every combination of core, contrib, -p1, -p0, apply, revert.
Comment #7
DrewMathers commentedThe above patch fails to handle the exception where a patch is partially applied. Here is a correction.
Comment #8
zet commentedThanks DrewMathers for your patch. Really helpful !
Comment #9
DrewMathers commentedComment #10
aidanlis commentedThanks, fixed ... really sorry about the delay.