Problem/Motivation

Past_db isn't fully ported right now. There are still left-overs and unported code from 7.x.

Proposed resolution

Inspect all functions to check if they're still used.

Remaining tasks

Identify unported code, and left-overs from already ported code.
Remove or port it. Include test coverage.

Remove:
past_db.controller.inc
update functions in past_db.install

Contains (partly) unported code:
past_db.drush.inc
past_db.module
past_db.views_default.inc
views/*
src/Entity/PastEvent.php

User interface changes

None

API changes

None

CommentFileSizeAuthor
#4 past_db_needs_to_be-2468921-4.patch36.38 KBedurenye

Comments

arla’s picture

arla commented
Status: Needs work » Closed (duplicate)
Related issues: +#2428645: Links and severity filter in past view not working

This issue summary is too unspecific IMHO. The bugs actually mentioned are covered by #2428645: Links and severity filter in past view not working so I'm closing this as a duplicate.

I think the remaining test failures are completely or partly covered by #2468347: Fix schema definition for format_plural_*

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Closed (duplicate) » Active
Issue tags: +Needs issue summary update

The issue summary definitely needs work but I'd like to keep this one open. This is about a code/functions in past_db (specifically the .module file) that hasn't been ported or is a left-over from 7.x. All the functions there need to be inspected to check if they're still used. There's stuff like hook_entity_info() and entity url callbacks that are no longer called.

arla’s picture

arla commented
Issue summary: View changes
Issue tags: -Needs issue summary update

Took a quick look through the files, updated IS.

edurenye’s picture

edurenye commented
Status: Active » Needs work
StatusFileSize
new past_db_needs_to_be-2468921-4.patch36.38 KB

This is the first try, still needs more work, as there is an error when adding argument data field into a view. And with that I will be able to port the extended search view.

edurenye’s picture

edurenye commented
Status: Needs work » Active

I'm continuing with the changes in child issues.

edurenye’s picture

edurenye commented
Status: Active » Needs review

I think past_db is completely ported now.
I'll continue now with the port of past_form #2403659: Port past_form to Drupal 8

Status: Needs review » Needs work

The last submitted patch, 4: past_db_needs_to_be-2468921-4.patch, failed testing.

edurenye’s picture

edurenye commented
Status: Needs work » Needs review
edurenye’s picture

edurenye commented

Status: Needs review » Needs work

The last submitted patch, 4: past_db_needs_to_be-2468921-4.patch, failed testing.

edurenye’s picture

edurenye commented
Status: Needs work » Active
edurenye’s picture

edurenye commented
Status: Active » Fixed

Seems that everything is ported and works fine, so the port is closed.
If we see somthing else we will open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.