Is there a reason that the Password Trigger module creates it's own trigger tab?

Seems to me that it pollutes the space by creating unnecessary tabs. I'm also creating another module that creates a trigger and action and if I were to add that module and this one, the tabs would start getting pretty cluttered.

I wasn't involved in any of the design of this module so there may have been discussion about this already but I would propose that he password trigger be moved under the User tab since it is user related. This is a fairly straight forward change and I can also update the wording to be more inline with the other triggers.

Thoughts?

CommentFileSizeAuthor
#1 move_to_user_tab-2151845-1.patch1.3 KBaaronott

Comments

aaronott’s picture

aaronott commented
Status: Active » Needs review
StatusFileSize
new move_to_user_tab-2151845-1.patch1.3 KB

Attaching a patch for review and discussion. Again I'm happy to commit this but wanted to get it reviewed and discussed prior to jumping in.

bucefal91’s picture

bucefal91 commented

I agree with overall idea of this issue. I also think the trigger should be under "User" tab.

I've reviewed the patch and it looks good (I'd like to vote for RTBC). Maybe just change the label from "A password is updated" to something like "After user's password has changed". But this is minor and it's just my humble opinion.

By the way, the 7.x-1.x-dev does what it says it does: sends an email when you change password. Maybe you could tag 7.x-1.0-beta1 or 7.x-1.0-rc1 ? Having a release will give more credibility to your module in the eyes of Drupal sitebuilders.