There was a new release for https://www.drupal.org/project/coder/releases/8.x-3.0 for a few days ago which supports PHP CodeSniffer version 3.3.1.

Maybe the site needs to upgrade to the latest version of the Coder-module? :)

Comments

truls1502 created an issue. See original summary.

mario steinitz’s picture

I'd say, as long as the current Drupal Core (8.6.1 as of writing) still depends on coder 8.x-2.x, we shouldn't change the dependencies of PAReview.sh.

This allows for the PHP Code Sniffer 2.x @ignore directives to still apply as appropriate and gives the module developers some time to adapt their code accordingly.

But yes, as soon as Drupal core switches and has a release with PHPCS 3.x support, we should consider introducing it in PAReview.sh as well. We'll keep an eye on that topic.

truls1502’s picture

truls1502’s picture

truls1502’s picture

Status: Active » Postponed
klausi’s picture

Status: Postponed » Active

Core uses Coder 8.3.x now, so we can continue here.

  • klausi committed 44d154d on 7.x-1.x
    fix(coder): Update Coder to 8.3.x and make ESLint work again (#3001443)
    
klausi’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Active » Fixed

Updated Coder to 8.3.x, we lost DrupalSecure support but that should be ok for now.

ESLint should also be working now again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.