Closed (fixed)
Project:
PAReview.sh
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
21 Sep 2018 at 10:20 UTC
Updated:
18 May 2019 at 11:19 UTC
Jump to comment: Most recent
Comments
Comment #2
mario steinitzI'd say, as long as the current Drupal Core (8.6.1 as of writing) still depends on coder 8.x-2.x, we shouldn't change the dependencies of PAReview.sh.
This allows for the PHP Code Sniffer 2.x @ignore directives to still apply as appropriate and gives the module developers some time to adapt their code accordingly.
But yes, as soon as Drupal core switches and has a release with PHPCS 3.x support, we should consider introducing it in PAReview.sh as well. We'll keep an eye on that topic.
Comment #3
truls1502Sure, I have added an issue and patch on #3002206: Update the stable version of drupal/coder to ˆ8.3.1 which can be used once the parent issue #3001735: Not able to download 8.3.1 with composer is fixed :)
Comment #4
truls1502Comment #5
truls1502Comment #6
truls1502Postpone this issue once #3002206: Update the stable version of drupal/coder to ˆ8.3.1 is resolved.
Comment #7
klausiCore uses Coder 8.3.x now, so we can continue here.
Comment #9
klausiUpdated Coder to 8.3.x, we lost DrupalSecure support but that should be ok for now.
ESLint should also be working now again!