Great Module! @chriscalip

Does this module allow me to map a full URI (path) rather than a Domain?

I think you know my 'logic' in this request... just refer to http://drupal.org/node/1164544#comment-4509598

Congratulations on this new module!

I have not spent much time reading the source, but it appears that you increment the next CDN asset(eg: 1-4). That is a idea I once used before I came to Drupal CMS (back in the good ol' days or HTML+PHP - with no CMS learning curves and callbacks) :)

Basically, the word 'parallel' describes it well!

Comments

chriscalip’s picture

chriscalip commented
Version: » 6.x-1.x-dev

Yup the current branch handles this implementation:

http://img1.drupal.org
http://img2.drupal.org
http://s1.amazonaws.com/drupal_cdn
http://s1.amazonaws.com/drupal1_cdn
http://s1.amazonaws.com/drupal2_cdn
http://s1.amazonaws.com/drupal3_cdn

Peter Bowey’s picture

Peter Bowey commented

Refer #1
*Great*
Many thanks!

chriscalip’s picture

chriscalip commented
Status: Active » Fixed

I know what your thinking *wink*

http://s1.amazonaws.com/drupal-cdn
http://s1.amazonaws.com/drupal1-cdn
http://s1.amazonaws.com/drupal2-cdn
http://s1.amazonaws.com/drupal3-cdn
http://drupal-cdn.s1.amazonaws.com
http://drupal1-cdn.s1.amazonaws.com
http://drupal2-cdn.s1.amazonaws.com
http://drupal3-cdn.s1.amazonaws.com

Peter Bowey’s picture

Peter Bowey commented

@chriscalip

Again, many thanks for engineering this module!
It 'grows' well... within... the asset collective :)

chriscalip’s picture

chriscalip commented
Status: Fixed » Needs work

Major bug found .. this feature is not supported until this bug is fixed.

lots of css files have relative links case in point system.css

background: url("../../misc/tree-bottom.png");

The module only does a replace so this would be fine if it's only domain:

http://img1.drupal.org/../../misc/tree-bottom.png
css inteprets as :
http://img1.drupal.org/misc/tree-bottom.png

It would not be fine on a full uri path

background: url("../../misc/tree-bottom.png");
http://s1.amazonaws.com/drupal3-cdn
**module process**
http://s1.amazonaws.com/drupal3-cdn/../../misc/tree-bottom.png
css interprets as
http://s1.amazonaws.com/misc/tree-bottom.png

chriscalip’s picture

chriscalip commented
Status: Needs work » Active
chriscalip’s picture

chriscalip commented
Assigned: Unassigned » chriscalip
chriscalip’s picture

chriscalip commented
Priority: Normal » Critical
chriscalip’s picture

chriscalip commented
Category: support » bug
Peter Bowey’s picture

Peter Bowey commented

Refer #5

Yep, I had the same problem with just advagg + cdn :)

Then you get 404's - all because of [../../] css factors!

chriscalip’s picture

chriscalip commented
Status: Active » Needs review

I digged deeper into this and it turns out advagg_build_css_bundle already implements this feature. That was just me worrying about troubles that are not there.. me pretty much doing a run through of the process in my mind versus just actually looking with actual data. I doubled check on the contents of the aggregated data and there is no where to be found of instances of "../.. " case in point system.css ../../misc/tree-bottom.png advagg correct parses it as /misc/tree-bottom.png

I'll consider this as fixed until otherwise proven. Now peter bowey : i believe .. your glitch might be caused by something else.

chriscalip’s picture

chriscalip commented

looking into that something else ... i swear i saw this glitch too.!

chriscalip’s picture

chriscalip commented
Status: Needs review » Fixed

I cant seem to find that specific scenario for that something else. considered fix till further proof given.

Peter Bowey’s picture

Peter Bowey commented

Refer #12
Thanks @chriscalip

I see the 'collective' relative asset 'trim' problem only when I run the advagg 'rebuild' function.

It re-writes references to Drupal's /modules/system/system.css from:

background: #fff url(../../misc/progress.gif);
to
background: #fff url(http://s1.amazonaws.com/misc/progress.gif);
*but* it should be:
background: #fff url(http://s1.amazonaws.com/drupal3-cdn/misc/progress.gif);

Hence the 404, but only for one url referenced by the advagg 'batch' API.

I suspect this is NOT a real serious problem! More the nature of given implied references to the Drupal API 'batch' function that advagg uses (for rebuilding the asset collective).

I do note from reading 'carefully' the Drupal Module CDN notes, that a lot of what you would like to achieve is present (in some form) in various 'hidden' attributes of the CDN 'extended use notes'.

Many thanks.

chriscalip’s picture

chriscalip commented

See http://drupal.org/node/1182670#comment-4589940 -- problem fixed it seems.

chriscalip’s picture

chriscalip commented
Status: Fixed » Active

I am still not sure if the cdn portion of this module handles :

background: #fff url(http://s1.amazonaws.com/misc/progress.gif);
// *but* it should be:
background: #fff url(http://s1.amazonaws.com/drupal3-cdn/misc/progress.gif);

I confirm that the standalone parallel_css only partially handles this; the error is the instances of "../.."

chriscalip’s picture

chriscalip commented
Status: Active » Closed (won't fix)

Module Parallel_CSS got deprecated , CDN module is now providing this module's feature.