Problem/Motivation

After updating to 11.3.6, running a drush site-install throws an error. This blocks some of our CI pipelines we have which spin up a fresh Drupal site to run end-to-end testing on.

I'm able to reproduce locally as well, so I don't believe it's a pipeline or runner issue. This does not occur on 11.3.5.

 [error]  Error: Call to a member function removeComponent() on null in paragraphs_library_modules_installed() (line 35 of /var/www/html/web/modules/contrib/paragraphs/modules/paragraphs_library/paragraphs_library.module) #0 [internal function]: paragraphs_library_modules_installed()
#1 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(389): call_user_func_array()
#2 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(340): Drupal\Core\Extension\ModuleHandler->{closure:Drupal\Core\Extension\ModuleHandler::invokeAll():388}()
#3 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(388): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
#4 /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php(257): Drupal\Core\Extension\ModuleHandler->invokeAll()
#5 /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php(83): Drupal\Core\Extension\ModuleInstaller->install()
#6 /var/www/html/web/core/lib/Drupal/Core/Config/ConfigImporter.php(910): Drupal\Core\ProxyClass\Extension\ModuleInstaller->install()
#7 /var/www/html/web/core/lib/Drupal/Core/Config/ConfigImporter.php(632): Drupal\Core\Config\ConfigImporter->processExtension()
#8 /var/www/html/web/core/lib/Drupal/Core/Config/ConfigImporter.php(569): Drupal\Core\Config\ConfigImporter->processExtensions()
#9 /var/www/html/web/core/lib/Drupal/Core/Config/Importer/ConfigImporterBatch.php(31): Drupal\Core\Config\ConfigImporter->doSyncStep()
#10 /var/www/html/web/core/includes/batch.inc(300): Drupal\Core\Config\Importer\ConfigImporterBatch::process()
#11 /var/www/html/web/core/includes/form.inc(834): _batch_process()
#12 /var/www/html/web/core/includes/install.core.inc(647): batch_process()
#13 /var/www/html/web/core/includes/install.core.inc(565): install_run_task()
#14 /var/www/html/web/core/includes/install.core.inc(122): install_run_tasks()
#15 /var/www/html/vendor/drush/drush/includes/drush.inc(69): install_drupal()
#16 /var/www/html/vendor/drush/drush/includes/drush.inc(53): drush_call_user_func_array()
#17 /var/www/html/vendor/drush/drush/src/Commands/core/SiteInstallCommands.php(174): drush_op()
#18 [internal function]: Drush\Commands\core\SiteInstallCommands->install()
#19 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#20 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#21 /var/www/html/vendor/consolidation/annotated-command/src/CommandProcessor.php(175): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#22 /var/www/html/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(389): Consolidation\AnnotatedCommand\CommandProcessor->process()
#23 /var/www/html/vendor/symfony/console/Command/Command.php(341): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#24 /var/www/html/vendor/symfony/console/Application.php(1117): Symfony\Component\Console\Command\Command->run()
#25 /var/www/html/vendor/drush/drush/src/Application.php(201): Symfony\Component\Console\Application->doRunCommand()
#26 /var/www/html/vendor/symfony/console/Application.php(356): Drush\Application->doRunCommand()
#27 /var/www/html/vendor/symfony/console/Application.php(195): Symfony\Component\Console\Application->doRun()
#28 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(113): Symfony\Component\Console\Application->run()
#29 /var/www/html/vendor/drush/drush/src/Runtime/Runtime.php(40): Drush\Runtime\Runtime->doRun()
#30 /var/www/html/vendor/drush/drush/drush.php(140): Drush\Runtime\Runtime->run()
#31 /var/www/html/vendor/bin/drush.php(119): include('...')
#32 {main}.

Steps to reproduce

Upgraded codebase from 11.3.5 to 11.3.6. Paragraphs Library module is in use.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

nessthehero created an issue. See original summary.

herved’s picture

herved commented

Same here, git bisect led me to this commit https://git.drupalcode.org/project/drupal/-/commit/964198697b3af9ac07d9d... from #3572171: Persist is_syncing across container rebuilds

The call to \Drupal::isConfigSyncing() in paragraphs_library_modules_installed returns FALSE now on core 11.3.6 while it was returning TRUE before on 11.3.5

Edit: Maybe we need to update the sync detection

function paragraphs_library_modules_installed($modules, bool $is_syncing = FALSE) {
  if ($is_syncing) {
    return;
  }
  ...
herved’s picture

herved commented
Related issues: +#3584812: ConfigInstaller isSyncing does not persist to hook_modules_installed() when multiple modules are installed
nessthehero’s picture

nessthehero
he/him
commented

Thanks for discovering that core issue. I put the MR diff into composer as a patch and it cleared my issue! So this likely isn't an issue with paragraphs_library.

I'll leave it open in case there's anything actionable from #2, otherwise this can be closed.

herved’s picture

herved commented
Status: Active » Closed (duplicate)

Thanks for reporting @nessthehero, that core patch also works for me.
I'm closing this issue as duplicate then.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.