The patch added in #2788607: Empty required fields not providing meaningful error messages assumed the real_item_count still included the removed item. This is not the case in the EXPERIMENTAL widget that updates the field with no "confirm removal" button.
This causes an off by 1 error in the following scenario:
- A field with initially 2 paragraph items.
- Remove 1 item.
- Save the node / parent entity.
- An Error message is shown for "X field is required" even though there is 1 item.
Cause:
ParagraphsWidget::multipleElementValidate():
real_item_count = 1
remove count = 1
Which results in detection of an empty field.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | paragraphs-experimental-empty-check-fix-2893129-2.patch | 4.61 KB | recrit |
| #2 | paragraphs-experimental-empty-check-fix-2893129-2--tests_only.patch | 3.69 KB | recrit |
Comments
Comment #2
recrit commentedAttaching the fix and tests. The test only is meant to fail on the current code base.
Comment #3
miro_dietikerOh this is annoying :-)
But the original code also reads strange, say if there are multiple removals...
Let's get this fixed minimalistically.
Note that we are still thinking about offering something like the remove/undo button again, but we want to progress with cleaning the UI first a bit.
Comment #4
miro_dietikerComment #6
miro_dietikerCommitted. Time to get the counts right. :-)