Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.the latest version of media 7.x-2.14 was recently released and includes a patch that panopoly was previously using.
also, media_youtube 3.6 was released and has a lot of fixes since 3.0
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | panopoly_widgets-upgrade_media_and_media_youtube-2931757-18.patch | 1.1 KB | joseph.olstad |
Comments
Comment #2
joseph.olstadComment #3
joseph.olstadpatch 3 contains make patches used previously by openatrium.
so only the first patch 2372907 is no longer needed.
Comment #4
joseph.olstadpatch 2372907 is included in the media 7.x-2.14 release. The other two are still needed.
Comment #5
dsnopekComment #6
dsnopekHere's a Travis build with this patch:
https://travis-ci.org/panopoly/panopoly/builds/323067655
Comment #7
joseph.olstadNice green
Comment #8
joseph.olstadinstead of media_youtube 3.6 might be best to go with 3.5 until I fix a recently reported regression in the recent 3.6 release.
#2932942: 7.x-3.6 regression. Youtube iframe lost width configuration
or postpone the change to media_youtube until I fix this or confirm whether or not it's really a regression.
Might just be a configuration issue or a pebkac issue.
Comment #9
byronveale CreditAttribution: byronveale at Princeton University commentedUpdated patch attached that uses media-7.x-2.16 instead.
Comment #10
joseph.olstadFYI I just tagged and released media_youtube 3.7 , removed the commit that caused the reported regression. Recommended 3.7
https://www.drupal.org/project/media_youtube/releases/7.x-3.7
Comment #11
byronveale CreditAttribution: byronveale at Princeton University commentedAnd so here's an updated patch for that…
Comment #12
bkosborneWe've had this in production for a week w/o issue
Comment #13
byronveale CreditAttribution: byronveale at Princeton University commentedSecurity update media-7.x-2.19 is out, so here's a patch; includes media_youtube-7.x-3.7 too.
Comment #14
byronveale CreditAttribution: byronveale at Princeton University commentedComment #15
byronveale CreditAttribution: byronveale at Princeton University commentedOkay, so not sure why, but my build using the patch in comment #13 keeps crapping out, says "Could not locate media version 7.x-2.19", so here's a patch that uses a patched version of media-7.x-2.18 instead, this built properly.
Also, I discovered that the patch that was being applied to media-7.x-2.13 previously is no longer needed, so ignore the patch in comment #13.
Comment #16
byronveale CreditAttribution: byronveale at Princeton University commentedHeh, and now looks like media-7.x-2.19 is downloading properly, just built successfully using this patch. Sorry for all the activity…!
Comment #17
joseph.olstadnew file_entity release 7.x-2.21 has performance fixes , I recommend panopoly also upgrade file_entity to 7.x-2.21 due to performance fix
Comment #18
joseph.olstadmedia patches for SA and the accessibility patch are no longer needed with media 2.19 as they are included.
file_entity 7.x-2.21 includes a very important performance fix , significant performance improvement.
https patch for vimeo
Comment #19
dsnopekHere's a new test build:
https://travis-ci.org/panopoly/panopoly/builds/376041964
I'd really like to merge this soon to fix the "red shield" on the project page!
Comment #20
joseph.olstadhmm, what is this before_script?
Error: Timeout while waiting for webserver.
Error: ./.drupal-ti/runners/panopoly-behat/before_script.sh exited with a failure.
Comment #21
dsnopek@joseph.olstad: That was just some Travis fluke - a certain percentage of builds there just fail for unknown reasons. I re-ran the build and it passed!
Comment #23
dsnopekI did a bunch of manual testing and everything seems to be working with the updates! The Behat tests are pretty good on media, so I'm going to go ahead and commit this. Thanks, Everyone!