I'm in the process of upgrading my site to v1.5. I've upgraded the distribution which went almost completely painlessly until I noticed one of my pages was broken. I tracked it down to the Boxton template which now adds the class "container" in the first div. I have a mini-panel for an element of my site and I use Boxton for the layout. However, I have used the Skeleton theme on some of my pages and the container class is used by skeleton but it only expects it at the top level. Nested down inside a mini-panel it broke the theme. I've fixed it by having my own version of the boxton.tpl.php file.
Now, although I've made this a bug report, it's perfectly possible I've used the templates wrongly. If so, apologies and you can delete this. I'll have to overwrite it myself.
Comments
Comment #1
dsnopekHrm. So, those 'container' classes were added to make the Panopoly layouts compatible with Twitter Bootstrap, specifically as used by the Radix theme: #2050651: Make Panels layout from Panopoly Theme work with Radix
We're hoping to eventually include Radix in Panopoly: #1987386: Include Radix theme in Panopoly
In Bootstrap, you use 'container' any time you want to have a layout, either for the whole page or nested in another layout. Unfortunately, we weren't aware that the Skeleton theme had it's own way of using that class. :-/
Thanks for letting us know about this! I think your current fix (replacing the boxton.tpl.php) is a good idea. But I'm not sure what the "full" solution is...
Comment #2
PedroKTFC commentedAha! It is a bit of a pain as if I use any other layouts I'll have to update the tpl.php file. C'est la vie I guess.
Alternatively I guess I could change the container class from skeleton to something unique. Quite a few edits that's be.
Comment #3
dsnopekWe've switched from our custom layout's to Radix Layouts and they use
container-flluidso I hl think this is no longer an issue.