Radix is quite amazing and Atrium is using it as a base theme. It should be an option in Panopoly for others and this is a task to get us there.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shadcn’s picture

Assigned: Unassigned » shadcn

Working on this. :)

dsnopek’s picture

Since Radix uses Bootstrap and there are still the issue with Navbar conflicting with Bootstrap, we should probably resolve that first. You can find more information in this issue: #1971292: Minor fixes for Navbar module in panopoly_admin.make in comments #12 - #15.

shadcn’s picture

Yep. You're right. I submitted a patch a while back regarding this. https://drupal.org/node/1955912#comment-7377438

dsnopek’s picture

Well, this problem has already been fixed in Drupal 8 Toolbar, the changes just haven't been backported to Navbar yet. Here is an issue with a patch to do the backport: #1757466: Prefix all navbar classes to prevent theme clashes

lsolesen’s picture

It seems it has been backported now in the newest release of navbar.

@arshadcn and @dsnopek It is about time if Radix should make it before 1.0?

dsnopek’s picture

Issue summary: View changes
Issue tags: +sprint

I would LOVE for Radix to appear in Panopoly! :-)

However, there's two things that would be great to have worked out first:

I've already got so much going on for the 1.0 release (which we're targetting for next week), I'm not sure I'll have time to look at the layouts thing, personally. If @mrfelton or @populist could do it, that would be ideal! If not, I'll try and fit it in next week.

Adding to the sprint so this doesn't get lost.

shadcn’s picture

I can help with that. I'd try get a stable release for Radix this weekend and fix the layout thing as well.

dsnopek’s picture

Title: Enable Radix as a Theme for Panopoly » Include Radix theme in Panopoly

Arshad sent me this demo today - it's Radix 3 (based on Bootstrap 3) with a bunch of Bootswatch themes:

http://dev-radix.gotpantheon.com/demo

Looks awesome!

barraponto’s picture

https://github.com/barraponto/kw-skeletons/tree/panopoly-radix is my kraftwagen build of panopoly + radix_core. there's also https://github.com/barraponto/kw-skeletons/tree/panopoly-l10n which bundles panopoly + radix_core + l10n_install (yeah, I'm that crazy).

dsnopek’s picture

Added related issue!

dsnopek’s picture

Component: Admin » Theme
shadcn’s picture

dsnopek’s picture

Thanks, Arshad! I've made that issue related to this one as well.

barraponto’s picture

shadcn’s picture

Thanks Capi. I've moved Radix development to Github as well. I'll add you to the repo. We can still use the d.o issue queue.

My plan right now is to first make Radix stable, a 3.0 release, and then we integrate it with Panopoly.

caschbre’s picture

Where do we stand on this? Any issue holding up making this part of the 1.7 release?

dsnopek’s picture

Now that #2191069: Have Panopoly Theme depend on Radix Layouts (rather than providing it's own) is in, there's nothing holding this one back!

A couple random notes:

  • I think we should add Radix, but not set it as the default on install (at least not yet). I'd be open to switching the default at some point, but to get this merged sooner rather than later, let's just start with inclusion because that keeps the bar to review relatively low. We could open an issue making it the default after this one is in.
  • However, I'd be totally open to making it the install theme in this issue! It looks super nice as an install theme, let's just get a couple reviewer to run through the install to make there are no problems.
  • A new Radix release before we merge would be ideal, because I think the latest changes to radix_layouts make this commit important: http://cgit.drupalcode.org/radix/commit/?id=4171d8d5351b5ceb898566e56bba...

Anyway, this one should be much easier than the work to get radix_layouts in!

shadcn’s picture

Thanks @dsnopek.

If anyone wants to see the Radix theme as an installation theme, see http://simplytest.me/project/restaurant

dsnopek’s picture

Assigned: shadcn » Unassigned
Status: Needs work » Needs review
Issue tags: -sprint
FileSize
569 bytes
911 bytes

Here's some untested patches to get this started! I don't usually use the interactive installer, so I don't have a super convenient way to try things out. But I'll test this properly soon!

shadcn’s picture

Thanks @dsnopek. I can test this early tomorrow. I'll let you know.

caschbre’s picture

Setting this to needs work for the moment. There's a new version (3.0-rc2) out and separating out the installer theme as a separate issue #2445359: Use Radix as installer theme;

I've been using rc1 with only some minor issues that we can probably address later. I'll post screenies of that shortly along with an updated patch for the .make file.

  • Logo not displayed
  • Search block theming
  • Form fields full width
  • WYSIWYG profile dropdown width
caschbre’s picture

Status: Needs work » Needs review
FileSize
568 bytes

Attached is an updated patch that adds radix 3.0-rc2 to the .make file. The screenshots included on this ticket so far are based on rc2.

astringer’s picture

@caschbre re: Form fields full width

In Bootstrap inputs and selects havewidth: 100% applied by default. This makes sense in a mobile first theme. So that issue works as designed.

caschbre’s picture

@astringer... yeah, I don't disagree. I'm just pointing out some of the bigger differences that will impact the user experience. I think the full width is really only "broken" for the wysiwyg selection.

dsnopek’s picture

Yeah, it makes sense for a mobile first theme to set that, but when the window is at "desktop width" that particular field should continue to match the way it looks in responsive_bartik. So, we'll need a fix for that somewhere!

dsnopek’s picture

Issue tags: +sprint
astringer’s picture

Hi guys, When using Radix as the Admin theme -- I'm running into trouble, especially in views. The problems seem to resolve when I switch back to responsive Bartik. I've been documenting. I know you're thinking about adding Radix as the default theme eventually, so where should I post these issues? Adding the question here because of Caschbre's comments above.

dsnopek’s picture

@astringer: Thanks for testing! Please post any issues you find with Radix in its queue:

https://www.drupal.org/project/issues/radix?categories=All

Then please link to them from here so we know that we what issues need to be solved! The help in finding these bugs is much appreciated. :-) Thanks!

shadcn’s picture

@astringer: I've created a Panopoly component you can use when filing bugs for Radix.

dsnopek’s picture

@arshadcn: Thanks!

Also, when I was digging through the Radix queue today I found an issue to partially fix the issue with the text format select box originally mentioned in #21:

#2223365: Use input group component for Input Format Widget

I'd still like it to be smaller and right aligned on the desktop (and maybe tablet) breakpoint, but it gets things closer!

astringer’s picture

Thanks guys, when I'm done with the current project I'll roll them all up and post them at once. Unless I find something critical. New(ish) to Drupal and Panoply and Radix have both been very helpful. !!

dsnopek’s picture

lsolesen’s picture

@dsnopek and @archadcn What are the plans at the moment for Radix in Panopoly? Also seeing that Open Atrium will not use Radix in the future #2632892: Cannot use Radix as theme after 3.1 update

shadcn’s picture

Yeah Mike (@mpotter) and I talked about this. We are working on a solution for the Radix Sass files being compiled in the subthemes.

The main issue with the Radix + Open Atrium integration, as far as I know, was a subtheming proble,. We were in a situation where we had a base theme (radix), a distribution theme (oa_radix) and subthemes. This made things not easy to maintain when the base theme needs upgrades and has significant changes.

It was easier to have one base theme, in this case the oa_basetheme + the Open Atrium changes applied to it.

At its core, oa_basetheme is still Radix.

Scratch that. Looks like Atrium still has a base theme (oa_basetheme, a modified version of Radix) and a distribution theme (oa_theme).

delacosta456’s picture

hi all
i am a fan of Panopoly and can say that it would be nice to have this

However please let me ask for the future of this cause i can see that the last comment on this issu was since 4 years.

Thanks