If you do an empty search, you should have the message "Enter your keywords".

Attached is a failing Behat test for this functionality.

CommentFileSizeAuthor
#6 empty-search-message-2150047-6.patch996 bytesjessehs
#1 add-search-test.patch1.02 KBlsolesen

Comments

lsolesen’s picture

lsolesen commented
Status: Active » Needs review
StatusFileSize
new add-search-test.patch1.02 KB

Added test for the search functionality

lsolesen’s picture

lsolesen commented
Status: Needs review » Needs work

This test fails on purpose. If doing an empty search there should be a notice that you have to enter your keywords.

lsolesen’s picture

lsolesen commented
Title: Add Behat test for search » Empty search should yield message "Enter your keywords"
Issue summary: View changes
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Component: Code » Tests / Continuous Integration
jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Component: Tests / Continuous Integration » Search
Category: Task » Bug report

The related issue #2329387: Write Behat tests to ensure search works after install and provides facets should be where the test exists. This issue is the "fix-the-bug" issue.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Status: Needs work » Needs review
StatusFileSize
new empty-search-message-2150047-6.patch996 bytes

This patch adds in the missing title to the search box "Enter your keywords". The patch in related testing issue now has all 3 tests passing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Version: 7.x-1.0-rc5 » 7.x-1.x-dev
Status: Needs review » Fixed

Looks good, thanks! Committed.

  • dsnopek committed 9f42693 on 7.x-1.x 
    Update Panopoly Search for #2150047 by jessehs, lsolesen: Fixed Empty...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Setting back to Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.