so basically i get this errors when i install panels frame:
Notice: Undefined index: sites/all/modules/contrib/panels/js/panels-base.js in panels_frame_js_alter() (line 116 of ..\sites\all\modules\contrib\panels_frame\panels_frame.module).
Notice: Undefined index: weight in panels_frame_js_alter() (line 116 of ..\sites\all\modules\contrib\panels_frame\panels_frame.module).
Notice: Undefined index: scope in drupal_get_js() (line 4309 of ..\includes\common.inc).
Notice: Undefined index: sites/all/modules/contrib/panels/js/panels-base.js in panels_frame_js_alter() (line 116 of ..\sites\all\modules\contrib\panels_frame\panels_frame.module).
Notice: Undefined index: weight in panels_frame_js_alter() (line 116 of ..\sites\all\modules\contrib\panels_frame\panels_frame.module).
Notice: Undefined index: scope in drupal_get_js() (line 4309 of ..\includes\common.inc).

Panels version : version = "7.x-3.5"
CTools version : version = "7.x-1.7"
Panels Frame : version = "7.x-1.0-alpha4"

Comments

pushamd’s picture

Version: 7.x-1.0-alpha4 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new630 bytes

The solution that i found for the issue :

helior’s picture

Thanks for your patch PushaMD – while this may resolve the PHP warnings, it may also inadvertently override more properties than we'd want to. Perhaps an alternative would be to first check if $javascripts[$file] even exists before attempting to add a weight. I believe something like that would be less intrusive. Could you update your patch to reflect this minimal impact?

pushamd’s picture

Here is the correted patch, with the desired modifications.

helior’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sergiuteaca’s picture

Status: Closed (fixed) » Needs review
StatusFileSize
new461 bytes

Here is a simplified patch

fox_01’s picture

#6 works for me

helior’s picture

Status: Needs review » Fixed

@sergiuteaca agreed; I had merged essentially the same thing when the issue was closed 3 months ago https://github.com/helior/panels_frame/commit/635a11f55ef3af4c83dae267ab... Thank you for your patch, though!!

helior’s picture

Status: Fixed » Closed (works as designed)
nwom’s picture

Status: Closed (works as designed) » Reviewed & tested by the community

Sorry to re-open this again, but 7.x-1.x-dev and 7.x-1.0-alpha4 both do not include the commit above. Was the commit only applied to git?

  • helior committed 635a11f on 7.x-1.x
    Issue #2497327 by PushaMD: Notice: Undefined index: weight.
    
helior’s picture

Status: Reviewed & tested by the community » Closed (fixed)

Sorry NWOM, but it was only pushed to Github and not Drupal's git repository. It should now appear in 7.x-1.x-dev.