Closed (fixed)
Project:
Panels
Version:
6.x-3.x-dev
Component:
Drag and Drop display editing
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Jun 2010 at 22:43 UTC
Updated:
7 Jul 2010 at 03:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
merlinofchaos commentedHere's a patch for review. This will go in soon but I'm hoping there are some eyeballs to catch obvious errors.
Not yet done:
1) I just realized that I haven't added the checkbox "make this reusable" like custom content for CTools has. I'll add this next patch.
2) There's a couple of additional flexible features/cleanup I need to do. That may be separate. Particularly, finer control on classes, plus checking to see if we really *need* to render the left/middle/right divs inside a column and not rendering them if so. (we may also be able to simply avoid rendering column/row divs if columns and rows are, in fact, alone. Plus I want an option to fix the canvas width, and another option to disable the 99% scaling. These probably should be a separate patch but are part of this effort.
Comment #2
merlinofchaos commentedOh one other comment: Preview is lame right now because there's no content to preview it with. Need to make sure that provides custom content.
Comment #3
merlinofchaos commentedUpdated patch allows flexible layouts to be made reusable in the layout designer.
This one turned out not quite as nice as I would've liked, but it works; the workflow is different and I am sure that will confuse people, but the option to embed a form within a form is not there, and flexible has no visiblity into the actual panels edit form.
Comment #4
merlinofchaos commentedOh yeah. Still needs help to make the preview work.
Comment #5
merlinofchaos commentedOk the preview button works in this patch
Comment #6
realityloop commentedI found the process of selecting a saved layout when creating new panels logical.
Seems to work well, when viewing the front end version of the panel and using the "Customize this page" method of editing the panel there is no option to add node parts as you can from admin/build/pages editor.
Also there is currently no way to add content to regions that don't already contain some form of content when using "Customize this page", all I get are the save and cancel buttons.
I'd also suggest changing the checkbox title:
Do not switch this panel
to something like
Keep current panel layout flexible
Comment #7
merlinofchaos commentedThose seem to all be issues with the IPE, which is pretty new in -dev and definitely not ready for prime time. There is probably no option to add node parts because there's no node context available at that point. I'll have to take a look at that when I move on to the IPE later.
I like your wording for the checkbox more, definitely, and will switch to that.
Comment #8
merlinofchaos commentedOk, I fixed fixed the preview, cleaned up some code and committed this!
Comment #9
realityloop commentedCool!