PHP warnings [#364719]

Running Drupal 6.x-dev there's quite a few PHP warnings:

# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 439.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 448.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 449.
# notice: Undefined property: panels_plugin_display_panel_pane::$get_option in /sites/all/modules/panels/panels_views/panels_views.module on line 449.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 454.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 455.
# notice: Undefined property: panels_plugin_display_panel_pane::$get_option in /sites/all/modules/panels/panels_views/panels_views.module on line 455.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 463.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 467.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 470.
# notice: Undefined property: view::$total_rows in /sites/all/modules/panels/panels_views/panels_views.module on line 478.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 482.
# notice: Undefined variable: allow in /sites/all/modules/panels/panels_views/panels_views.module on line 483.
# notice: Undefined property: panels_plugin_display_panel_pane::$get_option in /sites/all/modules/panels/panels_views/panels_views.module on line 483.

Comment	File	Size	Author
#7	panels_364719.patch	6.47 KB	drewish
#5	panels_364719.patch	4.68 KB	drewish
#4	panels_364719.patch	2.25 KB	drewish
#3	panels_364719.patch	2.67 KB	drewish
#2	panels_364719.patch	1.05 KB	drewish

Comments

Comment #1

drewish commented 27 January 2009 at 00:06

Component:

Code

» Views panes

Comment #2

drewish commented 27 January 2009 at 04:38

Status:

Active

» Needs work

Status	File	Size
new	panels_364719.patch	1.05 KB

half the problem is that it was missing:

 $allow = $view->display_handler->get_option('allow');

not sure on the other bit causing:

# notice: Undefined property: panels_plugin_display_panel_pane::$get_option in /sites/all/modules/panels/panels_views/panels_views.module on line 451.
# notice: Undefined property: panels_plugin_display_panel_pane::$get_option in /sites/all/modules/panels/panels_views/panels_views.module on line 457.
# notice: Undefined property: view::$total_rows in /sites/all/modules/panels/panels_views/panels_views.module on line 480.
# notice: Undefined index: feed_icons in /sites/all/modules/panels/panels_views/panels_views.module on line 484.
# notice: Undefined index: feed_icons in /sites/all/modules/panels/panels_views/panels_views.module on line 485.
# notice: Undefined property: panels_plugin_display_panel_pane::$get_option in /sites/all/modules/panels/panels_views/panels_views.module on line 485.

Comment #3

drewish commented 27 January 2009 at 05:06

Status	File	Size
new	panels_364719.patch	2.67 KB

This gets it down to just:

    * notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 484.
    * notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 485.

Those seem like they need to have the feed_icons option added to the views_plugin_display class... but I'm not sure that's correct.

Comment #4

drewish commented 27 January 2009 at 05:15

Status:

Needs work

» Needs review

Status	File	Size
new	panels_364719.patch	2.25 KB

removed some whitespace changes. i guess is ready for review but as i noted in #3 there's more that could be done.

Comment #5

drewish commented 27 January 2009 at 19:29

Status	File	Size
new	panels_364719.patch	4.68 KB

Fixed a few more:

# notice: Undefined variable: items in sites/all/modules/panels/plugins/content_types/profile_fields.inc on line 21.
# notice: Undefined variable: pv in sites/all/modules/panels/panels_views/panels_views.module on line 511.
# notice: Trying to get property of non-object in sites/all/modules/panels/panels_views/panels_views.module on line 511.
# notice: Undefined variable: form in sites/all/modules/panels/panels_views/panels_views.module on line 608.

Still to be addressed:

# notice: Undefined index: context in sites/all/modules/panels/panels_views/panels_views.module on line 134.
# notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 484.
# notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 485.
# notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 548.
# notice: Undefined index: middle in sites/all/modules/panels/includes/display-edit.inc on line 205.
# notice: Undefined property: stdClass::$title in sites/all/modules/panels/includes/display-render.inc on line 187.

Comment #6

drewish commented 27 January 2009 at 19:13

marked #350997: Undefined property error as a duplicate

Comment #7

drewish commented 28 January 2009 at 03:30

Status	File	Size
new	panels_364719.patch	6.47 KB

Fixed a few more:

# notice: Undefined property: stdClass::$title in sites/all/modules/panels/includes/display-render.inc on line 187.
# notice: Undefined index: context in sites/all/modules/panels/panels_views/panels_views.module on line 134.

Still to be addressed:

# notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 484.
# notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 485.
# notice: Undefined index: feed_icons in sites/all/modules/panels/panels_views/panels_views.module on line 548.
# notice: Undefined index: middle in sites/all/modules/panels/includes/display-edit.inc on line 205.

Comment #8

merlinofchaos commented 29 January 2009 at 00:28

Committed #7. Leaving open as there are a few more to be addressed.

Comment #9

merlinofchaos commented 22 February 2009 at 21:19

Status:

Needs review

» Fixed

Of course, reading #8 I'm confused as to what more needs to be addressed. Let's mark this fixed and open new issues for additional notices.

Comment #10

8 March 2009 at 21:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

PHP warnings

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

News items

Our community

Documentation

Drupal code base

Governance of community