Panels already supports adding "more" links with custom text. Panel Views allows to add a custom "more" link with a configurable URL, but not with custom text. This patch adds the bits required to customize the link text to your likings.

CommentFileSizeAuthor
#4 screenshot.png14.85 KBsmk-ka
panels_views-more-text.patch4.44 KBsmk-ka

Comments

merlinofchaos’s picture

merlinofchaos commented

I'm not sure about this. Will this setting be confusing? Both Views and Panels offer a 'more' option and I am not completely sure that doing this won't create more confusion.

sdboyer’s picture

sdboyer commented
Status: Needs review » Postponed

I'm going to mark this as postponed. While I'll accept the possibility that there are indeed some compelling use cases for this (and I would like to hear examples), I'm getting to the point where I'm quite concerned about the already-overwhelming number of options Panels2 offers. I want to draw the line somewhere on adding more new little widgets like this until we have a better system for organizing such options altogether, as I feel like we've reached a saturation point on the widgets. (I also want RC out, I'll be honest).

Seriously though, if we continue to evaluate each little widget on a case-by-case basis, then the forms will just _keep growing_. I want to draw a line somewhere until we come up with our better, smarter way of containing these options, and I feel like this is a good place to draw it.

smk-ka’s picture

smk-ka commented

Our use case was a requirement to show something more meaningful than "more". For example, in the screenshot the link at the bottom reads "Show all new reviews".

However, maybe I've simply misunderstood (or not understood at all) the "two-layer" configuration (setting global and local defaults) for Views panes, since I just copy-pasted a field. Is this in preparation of user-customizable panels, or what exactly is it good for?

(Maybe this misunderstanding also explains #275828: Logic errors? Hadn't had time to think about Earl's response, though.)

smk-ka’s picture

smk-ka commented
StatusFileSize
new screenshot.png14.85 KB

Attachment didn't go through...

sdboyer’s picture

sdboyer commented
Status: Postponed » Fixed

OK, I reconsidered. I mean...it's useful, the patch works, and it's consistent with the style in which the rest of this is handled. I've debugged it pretty thoroughly, and aside from some minor tweaks to the .install file and some strings, I'm happy with it. Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

salvacion’s picture

salvacion commented

Is there any way we can hard code the "more" text without applying the patch? I'm creating a spanish site and I want the "more" link to read "más"

emarchak’s picture

emarchak commented
Version: 5.x-2.x-dev » 7.x-3.x-dev

I can't seem to find this feature in the 7.x-3.x stream. What happened to it? It seems like it should have been something that ought to have been ported over.

emarchak’s picture

emarchak commented
Status: Closed (fixed) » Active
merlinofchaos’s picture

merlinofchaos commented
Version: 7.x-3.x-dev » 5.x-2.x-dev
Status: Active » Closed (won't fix)

No, and that's because the sub-module this was for doesn't actually exist anymore. That whole methodology was changed in Drupal 6.

emarchak’s picture

emarchak commented

Is there a way to do this in D7? I was digging around for this functionality.

merlinofchaos’s picture

merlinofchaos commented

I think Views allows you to edit the more text now. Though, hm. views_content module may not actually pass that along. Not sure offhand.

You can always use template_preprocess_panels_pane and change the more link there.