In IE7, the JS helper that should select a certain layout's radio button on click on the image, doesn't work. The source code reveals a differently structured DOM for the radio elements, which is weird. I need to check what's wrong there.

CommentFileSizeAuthor
#5 panels-DRUPAL-5--2.choose-layout.patch3.27 KBsun
#4 panels-DRUPAL-5--2.choose-layout.patch2.44 KBsun
#1 theme_panels_layout_icon.patch1.31 KBpancho

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Active » Needs work
StatusFileSize
new theme_panels_layout_icon.patch1.31 KB

Oh, I found the problem: Block elements like

are not allowed inside inline elements like .
Firefox corrects this in the DOM, and places the div's outside the label, while IE doesn't care. Our JS was adapted to the DOM spit out by Firefox, so it obviously can't work on IE.

I replaced the div's in panels_print_layout_icon by span's, and voilà. I didn't find the time though to adapt panels_admin.css, so maybe someone can do that for me?

sdboyer’s picture

sdboyer commented

I can't test this (no IE set up atm in my env) - you worked on it anymore, Pancho?

merlinofchaos’s picture

merlinofchaos commented

I have IE6 and 7 available. I'll try to check on this in awhile.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: pancho » sun
Status: Needs work » Needs review
StatusFileSize
new panels-DRUPAL-5--2.choose-layout.patch2.44 KB

Goot cadch! :)

Attached patch works in Firefox + IE7.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new panels-DRUPAL-5--2.choose-layout.patch3.27 KB

Now incorporating #267299: Use clear-block in Panels layout form.

sdboyer’s picture

sdboyer commented
Status: Needs review » Fixed

Spiffy. Committed!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.