I'm trying to unfork a codebase someone else was managing and happened upon this one change that I can't figure out.

CommentFileSizeAuthor
#1 1069964_set_name_if_admin_title_is_missing.patch787 bytesgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 1069964_set_name_if_admin_title_is_missing.patch787 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Parent issue: » #1774796: Plan for Panels v6.x-3.11 release (PHP 5.4 fix)
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Postponed (maintainer needs more info)

Needs issue summary update and know why we really need to update the code like this. It looks very wrong to move the name inside admin->title check as the purpose of whole block of code is to provide mini->name 

if (empty($cache[$mini->name])) {
...
...
  // Translate old style titles into new titles.
  if (isset($mini->title) && empty($mini->admin_title)) {
    $mini->admin_title = $mini->title;
  }
  $cache[$mini->name] = $mini;
}
japerry’s picture

japerry
Location KOMK
commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing this issue as outdated as Drupal 6 ctools is not supported. If this issue is relevant for Drupal 7, feel free to re-open and mark for Drupal 7 (or 8)