There are several drupal_set_message() statements that aren't translated and are not set to avoid being repeated.

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new5.53 KB

Found these while working on something else.

devd’s picture

Hi,

I have reviewed the code there are some more errors.
1- 1333: In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data
2- Line 1951: In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data.
3- drupal_set_message()'s not translated.

I have fied all the above error in attached patch.

Regard
Devendra

  • DamienMcKenna committed b175697 on 7.x-3.x
    Issue #2337213 by DamienMcKenna: Some drupal_set_message strings were...
damienmckenna’s picture

@Devendra: Thanks, but could you please file a new issue for the SQL problems? Thanks.

damienmckenna’s picture

Status: Needs review » Fixed
Issue tags: -db_query, -docblo

I committed the patch in #1 above.

devd’s picture

Thanks Daminen

I have created the new issue. Please review the attached patch.

https://www.drupal.org/node/2337767

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.