There are several drupal_set_message() statements that aren't translated and are not set to avoid being repeated.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | not_translated_db_query_not_used_placeholders-2337213-2.patch | 14.41 KB | devd |
| #1 | panelizer-n2337213-1.patch | 5.53 KB | damienmckenna |
Comments
Comment #1
damienmckennaFound these while working on something else.
Comment #2
devd commentedHi,
I have reviewed the code there are some more errors.
1- 1333: In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data
2- Line 1951: In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data.
3- drupal_set_message()'s not translated.
I have fied all the above error in attached patch.
Regard
Devendra
Comment #4
damienmckenna@Devendra: Thanks, but could you please file a new issue for the SQL problems? Thanks.
Comment #5
damienmckennaI committed the patch in #1 above.
Comment #6
devd commentedThanks Daminen
I have created the new issue. Please review the attached patch.
https://www.drupal.org/node/2337767