Problem/Motivation

A page without variants doesn't create any routes, so there is no impact.
It makes it easier for site builders.

Proposed resolution

Add default config for /node/{node}

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2612174-default-2.patch1.37 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2612174-default-2.patch1.37 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2612174-default-2.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Fixed

Here's the fix for that fail:

diff --git a/src/Tests/PageManagerAdminTest.php b/src/Tests/PageManagerAdminTest.php
index 804edd7..afad115 100644
--- a/src/Tests/PageManagerAdminTest.php
+++ b/src/Tests/PageManagerAdminTest.php
@@ -44,6 +44,9 @@ protected function setUp() {
     $this->config('system.theme')->set('admin', 'classy')->save();
 
     $this->drupalLogin($this->drupalCreateUser(['administer pages', 'access administration pages', 'view the administration theme']));
+
+    // Remove the default node_view page to start with a clean UI.
+    Page::load('node_view')->delete();
   }
 
   /**

Committing this now.

  • tim.plunkett committed d8ef957 on 8.x-1.x 
    Issue #2612174 by tim.plunkett: Add a default page for /node/{node}

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.