Needs review
Project:
Overpass API
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2026 at 17:17 UTC
Updated:
18 Oct 2026 at 09:50 UTC
Jump to comment: Most recent
Split out of MR !9 on #3618910: Expose Surface for use with OpenStreetmap Module et al., per comment #10 there.
composer.json requires drupal/geocoder, drupal/leaflet and geocoder-php/nominatim-provider. drupal.org packaging only reads the root file, so every consumer installs them whether or not it uses the UI submodule.http://overpass-api.de/api/.tests/src/PHPCodeSniffer/Standard.php extends a class that does not exist in any PHP_CodeSniffer release, is referenced by no ruleset, and is the source of 56 coding-standards errors.suggest and require-dev, alongside drupal/feeds. The submodules' .info.yml dependencies already enforce them where they are used.core_version_requirement: ^10.3 || ^11 and php: 8.1 on every .info.yml.https://overpass-api.de/api/, with an update hook that moves sites still on the old http default..gitlab-ci.yml, phpcs.xml.dist, phpstan.neon and a .gitignore.tests/src/PHPCodeSniffer/Standard.php.703f91ff, 62c06d35, and the Standard.php removal from 2ed31651.Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
orkutmuratyilmaz@tbcs, thanks for splitting this out. With #3618910: Expose Surface for use with OpenStreetmap Module et al. merged I rebased the branch onto 1.0.x (no conflicts; your two commits keep your authorship) and pushed three commits on top. The packaging part is what I hoped for: geocoder, leaflet and the Nominatim provider move to
suggest,overpass_api_ui.info.ymlstill refuses to enable without them, andoverpass_api_update_10002()only touches sites still on the exact old default."Trim the docs and composer.json to what 1.0.x ships": the branch was written on top of the preset and Feeds work, so a few things described code that is not on 1.0.x, or changed after you wrote them:
{{bbox}}note was the opposite of what 1.0.x does:QueryBuilderForm::assembleRawQuery()still substitutes(%F,%F,%F,%F)with the parentheses. The note fits once the preset work lands.drupal/feedsfromrequire-devandsuggest, for the same reason.user_agent,chunk_size).OverpassApiExceptionitself._CSPELL_WORDS, which described nothing below it."Fix the cspell and phpcs findings" and "Fix the phpcs errors coder 8.3 reports": since this issue introduces the CI config, I cleaned up what it reports (the second commit because the pipeline runs coder 8.3.31 and I had first checked with 9.0.1; the two disagree on a few lines):
_CSPELL_WORDS, acspell:ignorefor "İzmir" inQueryBuilderTest, thebetweeentypo, "synchronized", and "Please" (forbidden by Drupal's dictionary) out of the flood message and a test remark. The cspell job is green now.use Urlinoverpass_api_ui.install, the lock message indentation inSettingsForm, fall-through comments inUtils::returnBytes(), two nested arrays inQueryBuilderTest). Checked with coder 8.3.31, which the pipeline uses, and with 9.0.1. The job stays red only on the 23 DrupalPractice "\Drupal calls should be avoided" warnings in the two forms, which go away with the dependency injection in #3630442: Inject services into SettingsForm and QueryBuilderForm, and lower the retry defaults.eslint (
query-builder-map.js) and phpstan (mostly\Drupalcalls in the two forms) are bigger and overlap with #3630442: Inject services into SettingsForm and QueryBuilderForm, and lower the retry defaults, so they stayallow_failurefor now.On the
^10.3floor: I could not find anything on 1.0.x that needs 10.3, so I read it as a support-policy change. That's fine with me, since 10.3 is out of security support; it goes into the 1.0.0-beta5 release notes.Please have a look at the three commits. I'd like this to land before 1.0.0-beta5, so the https default goes out with the #3618910: Expose Surface for use with OpenStreetmap Module et al. changes in one set of release notes. If nothing comes up, I'll merge it in a few days.
Comment #5
orkutmuratyilmaz@tbcs, I've just updated the MR !10's title and description too. Since my last comment, three more commits make every pipeline job green, eslint, phpcs and phpstan included:
\Drupal. That was planned for #3630442: Inject services into SettingsForm and QueryBuilderForm, and lower the retry defaults, which now keeps only the retry defaults.OverpassApiException; since #3618910: Expose Surface for use with OpenStreetmap Module et al. a failed status request ended in an error page.query-builder-map.js.Squash is off, so your two commits stay as they are in 1.0.x. If nothing comes up, I'll merge in a few days.