Problem/Motivation
Split out of MR !9 on #3618910: Expose Surface for use with OpenStreetmap Module et al., per comment #10 there.
The install defaults (180 s timeout, 8 s lock, 10 attempts) let a single failing call hold a PHP process for over half an hour. The two paths that run inside a web request, the settings form's test query and the query builder's "Run query", wait out that whole budget.
The dependency injection for SettingsForm and QueryBuilderForm that this issue first covered was done in #3630443: Move UI dependencies to suggest, default to the https endpoint, and add CI, because the CI jobs added there needed it. The Drupal 11 settings form fatal fix (d425b45a) is no longer needed: the fatal came from a new SettingsForm constructor, and #3630443: Move UI dependencies to suggest, default to the https endpoint, and add CI injects through create() instead.
Proposed resolution
- Lower the install defaults to a 60 s timeout and 3 attempts. Existing sites keep their configured values.
- The settings test query and "Run query" pass
maxAttemptsexplicitly throughOverpassQueryOptions, whichrawQuery()accepts since #3618910: Expose Surface for use with OpenStreetmap Module et al..
Remaining tasks
- The changes above.
- A functional test that loads the settings page, which also covers the injected services.
- Depends on #3630443: Move UI dependencies to suggest, default to the https endpoint, and add CI, which touches the same two forms.
Issue fork overpass_api-3630442
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
orkutmuratyilmazRetitled and updated the summary: the dependency injection for both forms landed in #3630443: Move UI dependencies to suggest, default to the https endpoint, and add CI, so this issue keeps the lower retry defaults, explicit
maxAttemptsfor the two web-request paths, and the functional test. The Drupal 11 fatal fix is dropped, since #3630443: Move UI dependencies to suggest, default to the https endpoint, and add CI does not add aSettingsFormconstructor.