This module have deprecated method and function

CommentFileSizeAuthor
#2 deprecated_methods_and_functions-2856506-2.patch24.53 KBznak

Comments

Znak created an issue. See original summary.

znak’s picture

znak commented
Assigned: znak » Unassigned
Priority: Normal » Major
Status: Needs work » Needs review
StatusFileSize
new deprecated_methods_and_functions-2856506-2.patch24.53 KB
tz_earl’s picture

tz_earl commented
Assigned: Unassigned » tz_earl
Priority: Major » Normal
tz_earl’s picture

tz_earl commented
Status: Needs review » Needs work

Unfortunately, after applying the provided patch, most of the automated tests for this module fail. Also, many warnings are generated that were not present before.

znak’s picture

znak commented
Status: Needs work » Postponed (maintainer needs more info)

@tz_earl, please, need more information about warnings.

tz_earl’s picture

tz_earl commented

@Znak This module has nine automated tests that can be run by using the core Testing module. The tests are grouped under the name "Optimizely".

The test results will show red for any failures and yellow for warnings, aka exceptions.

Please run all of the tests and check the results. I always use these in addition to manually testing the functionality and the rendering of the module.

  • tz_earl committed 2218305 on 8.x-1.x authored by Znak 
    Issue #2856506 by Znak: Deprecated methods and functions
tz_earl’s picture

tz_earl commented
Status: Postponed (maintainer needs more info) » Fixed

@Znak Your patch for replacing the deprecated db_* functions worked fine, so I gave you credit in one of the git commits.

However, the other functions were not just simple string replacements. They took some study of the code to figure out the proper changes. Please keep that in mind, and please use any automated tests that are provided.

This issue has been fixed as of version 8.x-1.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.