It should be up to the user if they want the search result feeds enabled or not (and I think it should be enabled by default since it rocks).
It should be up to the user if they want the search result feeds enabled or not (and I think it should be enabled by default since it rocks).
Comments
Comment #1
avpadernoIt makes sense to add such setting if the setting allows to decide which feeds should be enabled (basing on the module that implements
hook_search()). I think that by default all the feeds should be enabled (which means that when the setting has not been set, the module should show all feeds).Comment #2
avpadernoIsn't this feature report a duplicate of #663356: Choose what search hook should be opensearched?
Comment #3
dave reidNo, this is about the *results* feeds. That's about which modules are supported entirely.
Comment #4
avpadernoAs the OP is talking of feeds, I take he is talking of result feeds, although the patch he provided doesn't seem to change the way the feeds are generated.
I would rather merge the two feature requests, keeping this one as the other one doesn't provide a correct patch (nor a patch we would use; see the terminology used that refers to the OpenSearch descriptors as files). it doesn't make sense to alter the settings page to add this feature, and then altering it again to add the other feature; it would rather be better to alter the settings page once to add the settings form fields for both the features.
Comment #5
avpadernoComment #6
avpadernoI have marked #663356: Choose what search hook should be opensearched as duplicate of this feature request.
Comment #7
avpadernoRather than having settings valid for all the search pages, it would be better to have separate settings, and default settings. This would allow to have a description for each module implementing the search hook.
If then the user doesn't have any need to have values specific for a search page, then he will use only the default settings.
Comment #8
avpadernoComment #9
avpadernoThe code has been changed, and committed in CVS.