It should be up to the user if they want the search result feeds enabled or not (and I think it should be enabled by default since it rocks).

Comments

avpaderno’s picture

It makes sense to add such setting if the setting allows to decide which feeds should be enabled (basing on the module that implements hook_search()). I think that by default all the feeds should be enabled (which means that when the setting has not been set, the module should show all feeds).

avpaderno’s picture

Isn't this feature report a duplicate of #663356: Choose what search hook should be opensearched?

dave reid’s picture

No, this is about the *results* feeds. That's about which modules are supported entirely.

avpaderno’s picture

As the OP is talking of feeds, I take he is talking of result feeds, although the patch he provided doesn't seem to change the way the feeds are generated.

I would like to omit the user and node feed but currently, the OpenSearch Feed module is not up to the job.

I would rather merge the two feature requests, keeping this one as the other one doesn't provide a correct patch (nor a patch we would use; see the terminology used that refers to the OpenSearch descriptors as files). it doesn't make sense to alter the settings page to add this feature, and then altering it again to add the other feature; it would rather be better to alter the settings page once to add the settings form fields for both the features.

avpaderno’s picture

Title: Provide a setting to enable or disable the results feeds » Provide a setting to enable or disable the results feeds, and the OpenSearch descriptions
avpaderno’s picture

I have marked #663356: Choose what search hook should be opensearched as duplicate of this feature request.

avpaderno’s picture

Title: Provide a setting to enable or disable the results feeds, and the OpenSearch descriptions » Provide settings for each search pages
Assigned: dave reid » avpaderno

Rather than having settings valid for all the search pages, it would be better to have separate settings, and default settings. This would allow to have a description for each module implementing the search hook.

If then the user doesn't have any need to have values specific for a search page, then he will use only the default settings.

avpaderno’s picture

Title: Provide settings for each search pages » Provide settings for each search page
avpaderno’s picture

Status: Active » Fixed

The code has been changed, and committed in CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.