error msg when encrypting outgoing emails

I still get this, it isn't fixed in 6.x-1.0-beta1 if the recipient has an empty PGP key.

The problem appears to be fixed by changing:

        else if (!is_null($v)) {
          $result .= ' --' . $k . ' ' . escapeshellarg((string)$v);
        }

to this:

        else if (!is_null($v)) {
          // convert object recipient into recipient email string
          if (is_object($v)) {
           $v = $v->mail;
          }
          $result .= ' --' . $k . ' ' . escapeshellarg((string)$v);
        }

The code seems to be expecting "recipient" to have a value that can be cast to a string, when in my case it's an object with the recipient email address as its mail attribute.

This code in openpgp_mail_parse_recipients() sets a recipient to be either a user object, or an email address.

    if (($account = user_load(array('mail' => $recipient)))) {
      $recipients[$account->uid] = $account;
    }
    else {
      $recipients[$recipient] = $recipient; // TODO: look it up on the keyservers?
    }

Do we need the whole user $account? Why are we loading a user if one matches an email address? Ah, of course, so we can look for their PGP key data in their profile later.

#3 fixed it for me in the 7.x port as well.

For what it is worth, here's fonant's fix in a patch for d6.