code overwrites $short_names array rather than merging it.

I've changed the code as follows:

if (isset($attributes['openid.ax.if_available'])) {
$short_names += explode(',', $attributes['openid.ax.if_available']);
}
if (isset($attributes['openid.ax.required'])) {
// $short_names += explode(',', $attributes['openid.ax.required']);
$short_names = array_merge($short_names, explode(',', $attributes['openid.ax.required']));
}

by merging the array, we're no longer overwriting the initial entries, but adding to it.

Comments

mgeurts’s picture

Status: Needs review » Active
mgeurts’s picture

Status: Active » Needs review
StatusFileSize
new782 bytes

  • sanduhrs committed cc64590 on 7.x-1.x authored by mgeurts
    Issue #1935714 by mgeurts: if both "if_available" and "required" on AX...
sanduhrs’s picture

Issue summary: View changes
Status: Needs review » Fixed

Thanks for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.