Problem/Motivation

The latest version of oa_core makes calls to oa_core_get_titles passing 0 as the $limit parameter. This causes file titles to disappear from the treeview widget. I believe the intention is to retrieve all titles.

Proposed resolution

Rather than need to send in magically large values, let a value of 0 or NULL return all values.

Remaining tasks

None known

User interface changes

None known

API changes

Any code making a call to this function with a 0 limit parameter intentionally to retrieve no results will suddenly receive results. I believe this is acceptable as I can see no side effects from this function that would cause someone to want to call it without getting the results back.

CommentFileSizeAuthor
#1 oa_core-unlimited_titles-2464845-1.patch537 bytestekante

Comments

tekante’s picture

tekante commented
Status: Active » Needs review
StatusFileSize
new oa_core-unlimited_titles-2464845-1.patch537 bytes
mpotter’s picture

mpotter commented
Status: Needs review » Reviewed & tested by the community
hefox’s picture

hefox commented
Status: Reviewed & tested by the community » Fixed

Had theis exact change sitting in my local uncommited XD Sorry about that

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.