Summary

Notification options for spaces are not correctly inherited by sections (and therefore not correctly inherited by content created in those sections).

Steps to recreate

Create a user with the default notification settings (instant email).

Create a space and add the user to it. Then add the user to the notifications options for that space.

Update the space. Message says '1 notification sent', but no email notification is sent out.

Create a 'news section' within that space. The notification options appear to be inherited from the parent space on the node edit form; but on saving the section no message appears to say that a notification has been sent, and no email is sent.

Create a piece of content within the section: the notification options are blank and no email notifications are sent.

Edit the parent section and override the notification options - add the user. Then edit the node and save it. A notification message is sent out to the user to say that the section has been updated.

Create a piece of content within the section: the notification options are inherited from the section correctly.

CommentFileSizeAuthor
#7 2295649-oa_messages_message_notify.patch1.42 KBslucero
#6 oa_messages_message_notify.diff1.6 KBchertzog

Comments

jkingsnorth’s picture

jkingsnorth commented
Issue summary: View changes
Aptalops’s picture

Aptalops commented

Following this thread as I have a similar problem.
A~

jkingsnorth’s picture

jkingsnorth commented
Issue summary: View changes
jkingsnorth’s picture

jkingsnorth commented
Version: 7.x-2.19 » 7.x-2.21

Marked #2323427: Notification emails are not being sent as a duplicate which suggests this is also a problem in 2.21.

jkingsnorth’s picture

jkingsnorth commented
Title: Notification settings not inherited correctly from spaces to sections » Notifications for spaces not sent and settings not inherited correctly from spaces to sections
chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Active » Needs review
StatusFileSize
new oa_messages_message_notify.diff1.6 KB

Here is a patch that makes things work for me. Im sure this isnt the right way of doing things, but it may provide insight as to what the underlying issue is.

slucero’s picture

slucero
he/him
Primary language English
commented
StatusFileSize
new 2295649-oa_messages_message_notify.patch1.42 KB

I was getting warnings that the patch from #6 was corrupt when trying to apply it, so I've applied it manually and attached a rerolled version.

mpotter’s picture

mpotter commented
Status: Needs review » Needs work

The patch in #7 applies to the message_subscribe module, which isn't a module I have direct control over. Either this issue needs to be opened over in the message_subscribe module queue or a different patch needs to be made that only requires changes to oa_* modules here.

Argus’s picture

Argus commented

This isn't going to work as Gizra has moved their issues for message_subscribe to GitHub.

Posted it here: https://github.com/Gizra/message_subscribe/issues/12

mpotter’s picture

mpotter commented
Status: Needs work » Fixed

This is also probably already fixed by the recent rewrite to oa_notifications. The OP about inherited notifications seems fine in my testing here. So marking this as fixed. Create a new issue if there is still a problem in the latest version that can be fixed within Open Atrium.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.