Problem/Motivation

A couple of endpoints used are custom made with jsonapi_resources. These endpoint can return multiple resource types so a schema is not created for them. In my application I extended the JsonApiGenerator to add some workarounds for custom endpoint so these can be included in the swagger documentation. To extend the class and use the necessary functions,

private $paramConverterManager -> protected $paramConverterManager

Steps to reproduce

Proposed resolution

For now changing this to protected is enough, since the solution I have is not reusable for the most

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3499594.patch555 byteswaropd

Comments

waropd created an issue. See original summary.

waropd’s picture

waropd commented
StatusFileSize
new 3499594.patch555 bytes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review

I agree, making this private breaks the possibility for us to extend this class, if it is not intended to be extended, it should probably be final so it's not even possible.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Directly moving this to rtbc, since it's not only widens visibility, so it cannot be considered an API break, nor can it break other implementations.