The openapi_json_schema submodule was first created in the Waterwheel module as waterwheel_json_schema because the Schemata module was not ready yet.
All the code was imported from there.

Now that schemata has a 8.x-1.0-alpha1 release it probably makes sense to rely on this module again and remove openapi_json_schema.

Comments

tedbow created an issue. See original summary.

martin107’s picture

Assigned: Unassigned » martin107
Status: Active » Needs review
StatusFileSize
new63.5 KB

Just a first draft removing the sub module and references in the parent module.

tedbow’s picture

StatusFileSize
new62.86 KB

@martin107 thanks for getting things started.

We are going to need a small change to the schemata module: #2870904: Add entity type only schema routes for entity types with bundles

I have made pull request.

Here is patch that should get the tests passing using the schemata module once the PR is accepted.

tedbow’s picture

StatusFileSize
new63.22 KB

Forgot to remove openapi_json_schema from the test

martin107’s picture

@tedbow

the link in #3 is circular - it points back to this issue.

would you repost the link.

The last submitted patch, 2: module-2870393-2.patch, failed testing.

The last submitted patch, 3: 2870393-3-schemata.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2870393-4-schemata.patch, failed testing.

tedbow’s picture

Status: Needs work » Needs review
StatusFileSize
new243 bytes
new63.18 KB

Adding schemata as dependency so the test bot will find it. Sub module won't work.

Test will still fail because changes to Schemata are still needed.

Status: Needs review » Needs work

The last submitted patch, 10: 2870393-10-schemata.patch, failed testing.

tedbow’s picture

Status: Needs work » Fixed

This is fixed in 8.x-1.x

tedbow’s picture

Assigned: martin107 » Unassigned

Unassigning since fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.