Are there any plans on making this module compatible with og 2 soon? For example I get this error when using current og_workflow with og 2 (on drupal 7):

Warning: Missing argument 1 for og_roles(), called in .../modules/og_workflow/og_workflow.module on line 232 and defined in og_roles() (line 2454 of .../modules/og/og.module).

I'd be really grateful to have this fixed.

CommentFileSizeAuthor
#2 og_workflow-7.x-2.x.patch18.64 KBTim-Erwin

Comments

Tim-Erwin’s picture

Tim-Erwin commented
Assigned: Unassigned » Tim-Erwin

Ok, I'm working on this. Would be nice to get some suggestions on how to attac this, because it's not simply about subtle API changes. Each group type now has its own set of roles. Hence we need to display and account for all roles in all group types (each has its own id). Where and when could I meet a maintainer on IRC?

Tim-Erwin’s picture

Tim-Erwin commented
Status: Active » Needs review
StatusFileSize
new og_workflow-7.x-2.x.patch18.64 KB

Well, attached you find a patch that makes og_workflow compatible with og-7.x-2.x. Would be great if you could apply soon or give me permission to do so.
The patch also changes the database storage to be equal to the workflow module's behavior: roles are stored as a comma separated list. Otherwise a string like "1234" could mean roles "1", "2", "3", "4" or "12", "34" etc.
Moreover I added documentation and refactored some functions in order to remove duplicate code.

shenzhuxi’s picture

shenzhuxi commented

I've give you the permission for commit to git.
You can create 7.x-2.x branch now.

Tim-Erwin’s picture

Tim-Erwin commented
Status: Needs review » Fixed

Thanks! I created the branch. You can add the new release...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit fb71f1b on master, 7.x-2.x by Tim-Erwin: 
    Issue #1605542 by Tim-Erwin: upgrade to og-2.x