Complete rewrite

we will need a proper og_menu very soon too. let's collaborate. care to share some code? doesn't matter if it's still broken/pre-alpha/ugly but then we can work on the same codebase.

I skimmed the current code, and I very much like where this is going. Great work! Much cleaner than the previous version!

I'm perfectly OK with just having one menu per group. This keeps the code flow much simpler for now. In the project I need this for we won't need more than one menu per group anyway.

I will review the code more closely and actually test it tomorrow or the day after tomorrow.

Will there be an upgrade path from 6.x-1.x to 6.x-2.x? I have a site almost ready to go live still running 6.x-1.3, and I am a little worried about whether I'll be able to upgrade this module...

Thanks for the note - right now, menus are only used on a 1:1 basis, and they're working fine. I'll put it on my dev server and see how the upgrade works. I probably won't get around to it until late next week, though.

Thanks for taking over this module. I've spent a few hours testing the dev version and have the following comments:

1) It works much better than 1.3 - thanks.

2) For a user with "Administer Menu" permission, all menus on the system are shown in the "parent item" drop-box. If the user only has "Administer OG Menu" permission then they only get the correct menus for their group, but then the following message occurs when trying to create a node:
warning: Invalid argument supplied for foreach() in /var/www/vhosts/thechurchinburton.org/httpdocs/sites/all/modules/og_menu/og_menu.module on line 211.

3) The block-og_menu class is used in both the inner and outer OG menu div, making it hard to style it properly (I want to style all the menus in the inner block, such as the one with ID block-og_menu-0-menu-og-7, but can't use the ID because that varies by menu).

Does your rewrite allow group members (or managers) to edit their own menus? I'm not finding a way to do that in 6.x-1.2...

If that's the case, I might be needing to use the dev version on a live site soon, which would mean I would be taking some extra time for code review :)

I've tried the 15 Jan version for point (2). I no longer get the error message but neither do I get the correct menus for the group when adding a new node. Instead, I get the menu for the first group that I created, irrespective of which group I'm adding to.
It does seem to keep the right group if I'm changing a node that already has a menu entry in place.

@jide I've been testing point (2) a bit more and it seems that the reason the fix doesn't work for me is that I have a Rule to hide og_nodeapi, which is where you've picked up the menus from. I'm trying to make things simple for my users, so hiding the ability to pick multiple groups seemed like a good idea. I'll try and test a bit more to see if the problem is fully fixed when the Rule is inactive.

@jide

Following on from #19, I've done more testing and can confirm that there is a problem even without my rule in place. It seems to be connected to the audience checkboxes (og_nodeapi).
On the Organic groups configuration page, there is an "Audience checkboxes" setting. If that is ticked then the latest dev version of OG Menu works OK. If it is unticked to simplify things for the user then it isn't possible to add new posts into the group.

Test case 1 - Organic groups configuration: Audience checkboxes unticked

When creating a new group, the audience checkboxes (og_nodeapi) are not shown, just the default group.
When trying to add a menu item, the only group menu shown is that for the first group added.
When trying to save, the following appears:

You cannot add menu items to this menu. Choose another parent menu.

Test case 2 - Organic groups configuration: Audience checkboxes unticked
when trying to edit an existing post on the group menu, the audience checkboxes appear and the correct menu is shown.

Test case 3 - Organic groups configuration: Audience checkboxes ticked
Can add OK

Test case 4 - Organic groups configuration: Audience checkboxes ticked
Can edit existing post on menu OK.

Patch that seems to fix #20

--- og_menu.old/og_menu.module 2010-01-23 22:14:41.000000000 +0000
+++ og_menu/og_menu.module 2010-01-23 22:09:09.000000000 +0000
@@ -225,7 +225,13 @@
}
// Otherwise, the user may only set to one group.
elseif (!empty($form['og_nodeapi']['invisible']['og_groups'])) {
- $groups[] = $form['og_nodeapi']['invisible']['og_groups']['#value'];
+ $groups1 = $form['og_nodeapi']['invisible']['og_groups']['#value'];
+ if (is_array($groups1)) {
+ $groups[] = array_shift(array_keys($groups1));
+ }
+ else {
+ $groups[] = $groups1;
+ }
}

$list = array();

Patch isn't indentented properly in above post. I don't know why because it pasted OK. I think its pretty easy to see what is intended though.

@brim - you'll need to either attach a .patch file to the post (use the File attachments form below the comment area), or paste it in with tags at the beginning and end...

OK, here is the file as a patch file

@jide - do you have a status update on the module/progress (not to rush or anything)? I'm thinking I might have time to do some more testing next week, and if things look good, I'll go live with the module when I launch the site in a few weeks (a pretty big site, so I want to make sure there aren't any show-stopping bugs).

The attached patch seems to fix any remaining issues with og_menu, it's working fine here.

Issues fixed:

-Issue adding Menus.
-Wasn't saving expand state on menu items from menu link list.

Just installed on our development environment. The only issue I can see right now is that the block is putting a div.block-og_menu inside of itself:

<div id="block-og_menu-0" class="block block-og_menu region-odd even region-count-3 count-4 with-block-editing"><div class="block-inner">
  <div class="content">
    <div id="block-og_menu-0-menu-archives" class="block block-og_menu region-odd odd region-count-1 count-1 with-block-editing"><div class="block-inner">
      <h2 class="title">Title of Menu Here</h2>
  <div class="content">
    <ul class="menu"><li class="collapsed first"><a href="/link" title="Link Title">Link Title Here</a></li>
    ...

If that one bug can be fixed, I can use this module on the new site I'm developing...

Also, a minor issue: the INSTALL.TXT file should read INSTALL.txt (lowercase).

Great work so far - this module is looking to be eons better than the previous revision!

[EDIT: I notice that you allow more than one menu in the block... this is all well and good, but could you possibly wrap the block in one class, and the internal menu blocks in another class? For instance, the main block class would be block-og_menu, and the internal blocks (for each internal menu) would be inner-block-og_menu or something like that...]

I think a release would be perfectly safe. It's an awesome module, and imho, this and OG Taxonomy should be standard fare on any 'true' organic-groups-enabled site.

Awesome! I'll download later today and do more testing.