Fixed
Project:
Organic Groups Menu (OG Menu)
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Aug 2026 at 04:28 UTC
Updated:
15 Sep 2026 at 05:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
joelpittetWhile adding coverage for the site-wide permission, I hit a pre-existing access bug that becomes reachable with this change.
OgMenuInstanceAccessControlHandleroverridescheckAccess()completely, which drops core's guard that forbids deleting an unsaved entity. This has existed since the handler was added, but no existing permission path granted delete access to a menu instance, so the result remained neutral and the existing test still passed.Once the global `administer og menu` permission grants delete access, that gap becomes visible and the test fails. The MR restores the guard in the access service:
It also adds coverage for an unsaved instance that has a group, which the existing test does not exercise.
I think this is small and closely related enough to keep here, but happy to split it into a follow-up if preferred.
Comment #4
joelpittetAdded the rename to the plan in the issue summary
'administer og menu instances'Comment #5
joelpittetWe need to cover edit/delete here too:
D7:

D10:

Comment #6
joelpittetProgress this is the result of applying MR:

Edit: the Audience field moving up and linking is totally unrelated (if you're wondering), that was just form display config
Comment #7
claudiu.cristeaLooks good to me. Feel free to merge when you consider. Thank you
Comment #9
joelpittetThanks again @claudiu.cristea for the review.
I put together a couple of quick roadmaps #3623047: [meta] 2.0.0-beta1 release roadmap and #3623048: [meta] 2.0.0 stable release roadmap