According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.

https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

Patch to follow, thanks!

CommentFileSizeAuthor
#9 Update_dependencies_format_in_info.yml_3005175-9.patch320 byteschipway
#6 oauth2_server-infofile-3005175-6.patch319 bytesvolkswagenchick
#5 oauth2_server-infofile-3005175-5.patch0 bytesvolkswagenchick
#4 oauth2_server-infofile-3005175-4.patch329 bytesvolkswagenchick
#2 oauth2_server-infofile-3005175-2.patch360 bytesvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Active » Needs review
StatusFileSize
new oauth2_server-infofile-3005175-2.patch360 bytes

I uploaded a patch that aligns the dependency namespacing to Drupal standards. Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: Unassigned » volkswagenchick
Status: Needs review » Needs work

I just noticed an empty space. patch forthcoming!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
Status: Needs work » Needs review
StatusFileSize
new oauth2_server-infofile-3005175-4.patch329 bytes

Okay updated the patch. Please review

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new oauth2_server-infofile-3005175-5.patch0 bytes

ok - This one is really the right one :)

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new oauth2_server-infofile-3005175-6.patch319 bytes

ugh. ok - let's try this one last time :)

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency namespacing aligns with Drupal documentation standards.
Patch applied via simplytest.me
Marking as RTBC
Thank you for working on module!

chipway’s picture

chipway commented
Assigned: Unassigned » chipway
Status: Reviewed & tested by the community » Needs work

Patch applies but it lacks a space.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3005175-9.patch320 bytes

Here is the new patch. Please review.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

The code looks good. The dependency namespacing was addressed. Patch applied using simplytest.me

Marking RTBC, and thanks for the fix @chipway. Good catch.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Version: 8.x-1.x-dev » 2.0.x-dev

  • sanduhrs committed 401a708 on 8.x-1.x authored by chipway 
    Issue #3005175 by volkswagenchick, chipway: Dependency namespacing in ....

  • sanduhrs committed d322802 on 2.0.x authored by chipway 
    Issue #3005175 by volkswagenchick, chipway: Dependency namespacing in ....
sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.