After creating my first task within a section, I got:

Notice: Undefined index: #name in comment_alter_form_comment_form_alter() (line 126 of /opt/development/mpotter/drupal/sites/all/modules/comment_alter/comment_alter.module).
Warning: Invalid argument supplied for foreach() in comment_alter_form_comment_form_alter() (line 151 of /opt/development/mpotter/drupal/sites/all/modules/comment_alter/comment_alter.module).

Also, the attachment image that I added to the original task is still being shown at the bottom. I think this is "by design" since it's showing all of the attachments for the Task. But it might be confusing for users who are used to the behavior of Discussions where the Attachment field below the comment is for the new reply and not the original post.

Maybe just the caption needs to be changed to "Attachments to the original issue"?

CommentFileSizeAuthor
#2 Selection_017.png19.88 KBdsnopek
#2 Selection_018.png44.45 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

For the notices, you're using an older version of Comment Alter. You need to use the one that'll get setup by the oa_worktracker.make file (it has some necessary patches). In fact, I'm surprised attachments work at all for you without the patches!

Once I get this Task in: #2106741: Improve diff for file attachments - they'll get a link to the actual attachment inside the diff which appears in the comment, so it won't be as weird. :-) But, yeah, we can change it to "Attachments to the original issue" as well!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Title: Warnings after creating a task » Usability improvements to comment form
Status: Active » Fixed
StatusFileSize
new Selection_018.png44.45 KB
new Selection_017.png19.88 KB

@mpotter: Remember to use oa_worktracker.make to get the correct comment_alter - that'll fix the warnings you got.

As far as reducing confusion on the comment form - I've made the following changes in 92f2094:

  1. Renamed "Attachments" fieldset to "Task attachments" when viewing inside the comment form
  2. Renamed the "Comments" header to "Updates and comments" (to emphasize that this is an audit log of the work done on this task
  3. Renamed the "Add new comment" header to "Update task and add new comment" (to emphasize that is how they update the task such that it appears in "Updates and comments" above)

I'm less sure about the wording for #2 and #3, but this is the best I've come up with so far. Below are some screenshots:

#2: Comments list

Selection_017.png

#1, 3: New comment header and attachments fieldset

Selection_018.png

Please let me know what you think!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.