Some part of the code like here, drupal service is being called try using dependency injection instead of that.

CommentFileSizeAuthor
#6 dependency_injection_3077852.patch2.08 KBpratik_kamble
#3 3077852-3-dependency.patch1.65 KBPavan B S

Comments

pallavisk created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented

I will be working on this issue

Pavan B S’s picture

Pavan B S commented
StatusFileSize
new 3077852-3-dependency.patch1.65 KB

Made changes as suggested please review

pallavisk’s picture

pallavisk commented
Status: Active » Needs review
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: Unassigned » pratik_kamble
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
StatusFileSize
new dependency_injection_3077852.patch2.08 KB

@pavan-b-s I have reviewed your patch you have added unneeded config_factory variable at line no. 19. Also, no documentation is added to the class variable.
I have attached new patch which contains the Dependency Injection.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Assigned: pratik_kamble » Unassigned
ambuj_gupta’s picture

ambuj_gupta commented

Tested and verified the module after adding the patch created by @pratik_kamble. And it is working as expected.

ambuj_gupta’s picture

ambuj_gupta commented
Status: Needs review » Reviewed & tested by the community
Lal_’s picture

Lal_
He\Him
commented
Status: Reviewed & tested by the community » Fixed

good fix

Lal_’s picture

Lal_
He\Him
commented
Lal_’s picture

Lal_
He\Him
commented
pratik_kamble’s picture

pratik_kamble
Location Pune, India
commented
Status: Fixed » Closed (fixed)