Hallo,

I really like this module and I hope that the changes you are working on will be available soon.

Until then it would be nice to know how I could do the following:
1. users can only enable/disable notifications in general, and on the users configuration page only the "Master switch" is shown.
2. notification mail should only show
- Greetings [user name],
- Number of new entries

I hope for help with a little note what to disable within the code of notify.module or notify.inc.

Thanks.

CommentFileSizeAuthor
#4 notify-86825-1.patch.txt8.31 KBkthagen
#3 notify-86825.patch.txt15.54 KBkthagen
#1 notify-enh.zip6.93 KBkthagen

Comments

kthagen’s picture

kthagen commented
Category: support » feature
Status: Active » Needs review
StatusFileSize
new notify-enh.zip6.93 KB

Here you go. I'm attaching the complete module to this comment. I'll provide a patch shortly. This is an extended version of the version that I recently posted here. Here's how it works:

  • On the admin/settings/notify page, there is a checkbox (enabled by default) indicating whether or not users should be able to see the content in their notification.
  • If you uncheck this box, users will only receive a count of new posts, and not the default title/author notice.
  • In this disabled state, users only see the master switch on their notification page.
  • On the admin/user/notify page, the settings that are hidden from users appear as deactivated fields. The current settings aren't changed, so you can turn the 'allow content' switch on and off without changing the user's underlying settings.
  • Install by overwriting notify.module. With this version, notify.inc is no longer necessary, and you can delete it.

Limitations:

If you turn off the allow-content choice, no count of comments is made at all.
You can't restrict users just to titles. IOW, currently, if you let them see any content at all, they can choose to see teasers or full nodes.

It would be nice to allow both count-only comment messages and title-only restrictions. I'll try to do that next.

RobRoy’s picture

RobRoy commented

@kthagen, I'll take a look at your patches shortly. Please make all patches according to http://drupal.org/diffandpatch and Drupal coding style. I'm looking forward to committing some new features to Notify. Thanks!

kthagen’s picture

kthagen commented
StatusFileSize
new notify-86825.patch.txt15.54 KB

As I said, the patch was forthcoming. And here it is. It's pretty long, though, since it incorporates all of this here as well. For reference, I'll send a diff of the two momentarily.

kthagen’s picture

kthagen commented
StatusFileSize
new notify-86825-1.patch.txt8.31 KB

And here's a diff between the patch for 28040 and this one.

RobRoy’s picture

RobRoy commented

Can you split up each piece of functionality in it's own patch? That will make it much easier to review. Thanks.

kthagen’s picture

kthagen commented

I looked at doing that, but it's hard to see how. This stuff really overlaps with the prior patch. I'd suggest reviewing that one first. With that factored out, this extension relatively small.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Needs review » Closed (won't fix)

After six years, chances are slim that these are going to be reviewed and backported into D4.
Time to close.