Problem/Motivation

Releases 7.x-1.4 and 7-1.6 of Notify has a bug that are somehow connected with the tests that are bundled with the project. Disabling tests removes the problem.

Release 7.x-1.4 produced a WSOD when the project was installed or upgraded (see #2949893: Update to 7.x-1.4 Breaks Site).

Release 7.x-1.6 can be installed OK, but according to comment #4, it produces: Error: Class 'DrupalWebTestCase' not found in include_once() after cache is cleared.

Since the bug cannot be reproduced by me, I need the community to assist in debugging notify.test.

Proposed resolution

Please test version 7.x-1.x-dev on your own site. It includes notify.test. If it reproduces the error described above (or any other error), try to fix it and post a patch here.

Please post the result of testing this version of Notify here whether it triggers the bug or not. Please include any data about your environment (OS, Drupal version, PHP version) that may help in reproducing this error.

Remaining tasks

  1. Wait for the community to test and review.
  2. Decide how to proceed based upon the community feedback.

Comments

gisle created an issue. See original summary.

  • gisle committed 2cc2fe0 on 7.x-1.x
    Issue #2954426 by gisle: Reincluded tests in 7.x-1.x branch
    
gisle’s picture

Version: 7.x-1.x-dev » 7.x-1.6
Status: Needs review » Fixed

Fixed in stable release 7.x-1.6.

dtesenair’s picture

Drupal 7.67
PHP 7.0

After upgrading to notify-7.x-1.6, I receive the dreaded Error: Class 'DrupalWebTestCase' not found in include_once() error AFTER i clear the cache on the site. The only way I have found to revive the site is to delete the 'notify' folder from the file system. After that, I can clear the cache and re-install the module. Everything seems to work fine until I clear the site cache again, which will result in the above error again.

I ran through this scenario a couple of different times with v1.6 and was able to to re-create the issue. I reverted back to v1.5 and things are running well now. so, it looks like the bug has not been fixed.

gisle’s picture

Title: Making a stable release 7.x-1.6 with tests reincluded » Making a stable release 7.x-1.8 with tests reincluded
Version: 7.x-1.6 » 7.x-1.x-dev
Status: Fixed » Active

dtesenair,
thank you for discovering this regression. Setting back to active.

Unfortunately, I am unable to recreate it on any of my sites (test or production), so I will need help from the community to debug this.

I am also going to make a stable release 7.x-1.7 without the test cases.

  • gisle committed deef1dc on 7.x-1.x
    Issue #2954426 by gisle: Regression. Notify without tests.
    
gisle’s picture

Version: 7.x-1.x-dev » 7.x-1.6
Issue summary: View changes

The tests are included in version 7.x-1.6 and excluded from version 7.x-1.7. Otherwise, they are identical.

I am unable to reproduce this (Drupal 7.67, PHP v7.0.44-0ubuntu0.16.04.6).

I need help from the community. Please test version 7.x-1.6. If it fails on your site (see issue summary), please try to debug the issue and post any information you can find here.

  • gisle authored 789a27e on 7.x-1.x
    Issue #2954426 by gisle: Added tests back to dev-branch.
    
gisle’s picture

Version: 7.x-1.6 » 7.x-1.x-dev

I've added the tests back to the dev branch, hoping to get this tested by more people.

The stable release 7.x-1.7 is without the tests, and is the one to use if you don't want to participating in debugging this.

I am still unable to reproduce this. Now running Ubuntu 20.04 LTS, Drupal 7.73, PHP 7.4.3.

Any precise instructions about how to reproduce this on a clean install will be much appreciated.

gisle’s picture

Issue summary: View changes
gisle’s picture

Status: Active » Closed (outdated)

Closing as outdated, please use this issue instead: #3246817: Enablings tests breaks some sites.