Add composer json file.

CommentFileSizeAuthor
#7 port_add_composer_json-2853742-7.patch645 byteskunalkursija
#3 composer.json_.txt410 bytesshylajaphp

Comments

kunal.kursija created an issue. See original summary.

shylajaphp’s picture

shylajaphp commented
Assigned: Unassigned » shylajaphp
shylajaphp’s picture

shylajaphp commented
StatusFileSize
new composer.json_.txt410 bytes
shylajaphp’s picture

shylajaphp commented
shylajaphp’s picture

shylajaphp commented
Assigned: shylajaphp » Unassigned
Status: Active » Needs review
kunalkursija’s picture

kunalkursija commented
Assigned: Unassigned » kunalkursija
Status: Needs review » Needs work

Hi @shylajaphp

There are few issues in the file. Like missing author details, Indentation issue, File Name is incorrect.

I am working on this to create a complete patch.

I will add the patch once I have 8.x branch created by the author.

kunalkursija’s picture

kunalkursija commented
Assigned: kunalkursija » Unassigned
Status: Needs work » Needs review
StatusFileSize
new port_add_composer_json-2853742-7.patch645 bytes

Adding Patch For Review.

kunalkursija’s picture

kunalkursija commented
Version: 7.x-1.0 » 8.x-1.x-dev
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Status: Needs review » Needs work 
+++ b/composer.json
@@ -0,0 +1,16 @@
+    "name": "drupal/noscript_tag",
+    "description": "Noscript tag module displays noscript tag when javascript is disabled in users browser.",
+    "type": "drupal-module",
+    "homepage": "https://www.drupal.org/project/noscript_tag",
+    "authors": [

Use an indent of 2 spaces.

Reference : https://www.drupal.org/docs/develop/standards/coding-standards#indenting

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Status: Needs work » Needs review

I am not sure, If 2 spaces indent is valid for composer.json file.

After checking Drupal Code compose.json it have 4 spaces indent.

http://cgit.drupalcode.org/drupal/tree/composer.json.

Updating status for needs review.

kunalkursija’s picture

kunalkursija commented

Composer has standard for 4 spaces, Which was recently followed by Drupal Too. Hence the 4 spaces.

polaki_viswanath’s picture

polaki_viswanath commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.