Closed (fixed)
Project:
Nodequeue
Version:
7.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Oct 2010 at 14:33 UTC
Updated:
7 Jan 2011 at 21:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
agentrickardFixes up a few autoloader issues and some stray Views integration.
Comment #2
brenk28 commentedHere is the same patch without the full file paths.
Comment #3
agentrickardThanks. Still adapting to git over here.
Comment #4
aanjaneyam commentedI don't know why I am getting this error when I click Structure->views after applying this patch.
Parse error: syntax error, unexpected T_DOUBLE_ARROW in /var/www/vhosts/ecoms.org.uk/subdomains/ecomstest/httpdocs/sites/all/modules/nodequeue/includes/views/nodequeue.views.inc on line 24
I have attached my nodequeue.views.inc below
Comment #5
agentrickard@amsri are you saying that the patch did that to your file?
Comment #6
agentrickardObviously something wrong with the patch, then.
Comment #7
agentrickardPatch applies fine for me.
patch -p0 < 941558-views-relationship_0.patchfrom the nodequeue root directory.Comment #8
aanjaneyam commentedI don't know what went wrong but I reapplied the patch using the patch on http://drupal.org/node/958100 and now it is the giving the error. Thanks for getting back.
Comment #9
agentrickardRight, sorry, this is a follow up to that issue.
[Edit: No it isn't, that other issue is a duplicate and causes the confusion.]
Comment #10
aanjaneyam commentedI need to correct my previous post I meant after applying the mentioned patch it is not giving the error. I did not get what you meant by follow up. Is it the same patch or the improved version of the patch at http://drupal.org/node/958100. BTW there are lots of issues which are preventing nodequeue from working properly. I just discovered another issue that I cannot just remove a node from queue (some recoverable fatal error - argument 2 etc.) After spending some time I have decided to leave the module till its next dev version is released which might improve things.
Comment #11
agentrickardOr you can file a new bug report for every D7 error you run into. We're patching as we go right now, and I'm not the module maintainer.
#958100: Drupal 7 Fixes is apparently a duplicate of this issue, so one patch needs to win out.
Comment #12
slashrsm commentedsubscribe
Comment #13
Scott Reynolds commentedThis patch is cleaner I think. Doesn't have to special case 0 (YIKES!), and uses FAPI states instead of the antiqued views dependency api.
Comment #14
agentrickardI would agree, but I need to test it out.
Comment #15
tekante commentedHere is an update to #13 that fixes the error observed in #10.
There is one other error I'm trying to track down. When on the admin/structure/nodequeue/QUEUE#/view/SUBQUEUE# path an error is generated:
Notice: Undefined offset: 5 in _menu_translate() (line 739 of /opt/development/cjohnson/www.house.gov/html/includes/menu.inc).
I believe it is due to the parent path having fewer substitutions than the default local task path but I'm not quite sure whether this is a core bug problem or an issue with the menu structure being created by the nodequeue module. Any pointers or suggestions would be appreciated. Note that I don't observe the error until the second time the path is loaded.
Comment #16
tekante commentedAttached is an update to #15 (I've also fixed the patch name to reflect the current issue queue). This patch makes the remove link on the subqueue page functional.
Let me know if you would like these as separate issues and patches. The system I'm working on has been using the patch from #11 (now the one in #15) to make the system functional in D7 so it's much easier to push the fix into the current patch until that gets committed to HEAD. I realize that might be complicating things though so if separate patches against the current HEAD and issue descriptions for each one are desired let me know.
Comment #17
berenddeboer commentedFixed my problems.
Comment #18
recidive commentedI'm getting this SQL error when accessing a view with nodequeue relationship and filter:
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'nodequeue_nodes_node.nid0' in 'where clause'.
Comment #19
meba commentedI am getting the same as #18
Comment #20
meba commentedRerolled, fixing #18
Comment #21
recidive commentedPatch in #20 is working for me, although if I add the "Nodequeue: queue" relationship plus the "Nodequeue: In queue" filter, you end up with only one item in the view. I'm not sure this is related to this issue, or if it's by design.
I'm marking as RTBC as adding only "Nodequeue: queue" relationship and checking the "Require this relationship" checkbox works as expected.
I'm rerolling the patch as the path in #20 has leading paths and don't apply cleanly.
Comment #22
ezra-g commentedThanks so much for all the re-rolls, folks! This is committed.
http://drupal.org/cvs?commit=469352